Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Update miscDeps to contain new brlApi module #9812
Link to issue number:
Summary of the issue:
The brlApi module in miscDeps is for Python 2.7. Not only is it the wrong Python major version, but the worse issue is that it depends upon msvcrt90 rather than msvcrt140 (like Python 3.7). Mixing different crts in the same process is not recommended and is dangerous.
Description of how this pull request fixes the issue:
Update miscDeps to latest master which contains the updated brlApi for Python 3.7. See pr nvaccess/nvda-misc-deps#14.
Known issues with pull request:
The brlTty braille Display driver has not at all been tested. There may be secondary issues with the changes to brlApi. However, other braille dirvers in the conversion to Python3 have not really been tested either, and most importantly this stops us loading an old crt into our process causing a freeze/crash.
Change log entry:
I would suggest we merge this as soon as we can, even before checking braille drivers, as this is the last thing blocking this branch from performing a full appveyor build. Successful builds would be a very good thing for validating future prs.