Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update miscDeps to contain new brlApi module #9812

Merged
merged 2 commits into from Jun 26, 2019

Conversation

@michaelDCurran
Copy link
Contributor

commented Jun 26, 2019

Link to issue number:

None.

Summary of the issue:

The brlApi module in miscDeps is for Python 2.7. Not only is it the wrong Python major version, but the worse issue is that it depends upon msvcrt90 rather than msvcrt140 (like Python 3.7). Mixing different crts in the same process is not recommended and is dangerous.

Description of how this pull request fixes the issue:

Update miscDeps to latest master which contains the updated brlApi for Python 3.7. See pr nvaccess/nvda-misc-deps#14.

Testing performed:

  • Reported by @leonardder that brlApi loads and connects.
  • Unit tests on appveyor no longer freeze.

Known issues with pull request:

The brlTty braille Display driver has not at all been tested. There may be secondary issues with the changes to brlApi. However, other braille dirvers in the conversion to Python3 have not really been tested either, and most importantly this stops us loading an old crt into our process causing a freeze/crash.

Change log entry:

None.

@michaelDCurran michaelDCurran requested a review from leonardder Jun 26, 2019

@michaelDCurran

This comment has been minimized.

Copy link
Contributor Author

commented Jun 26, 2019

I would suggest we merge this as soon as we can, even before checking braille drivers, as this is the last thing blocking this branch from performing a full appveyor build. Successful builds would be a very good thing for validating future prs.

@leonardder
Copy link
Collaborator

left a comment

Could you also update the version in the readme to 0.7.0?

@michaelDCurran michaelDCurran merged commit 1c474d9 into threshold_py3_staging Jun 26, 2019

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jun 26, 2019

@josephsl josephsl referenced this pull request Jul 23, 2019
107 of 107 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.