Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

appModule for VS Code to disable browse mode by default #9828

Merged
merged 1 commit into from Jul 1, 2019

Conversation

@leonardder
Copy link
Collaborator

commented Jun 27, 2019

Link to issue number:

None

Summary of the issue:

Visual Studio Code's primary goal is editing source code. However, as it is an electron app, browse mode is enabled by default.

Description of how this pull request fixes the issue:

Browse mode is now disabled by default on the appModule level.

Testing performed:

Tested that browse mode stays off by default in VS Code.

Known issues with pull request:

None

Change log entry:

  • Changes
    • In Microsoft Visual Studio Code, browse mode is now off by default.

Cc @bramd

@leonardder leonardder requested a review from feerrenrut Jun 27, 2019

@feerrenrut feerrenrut merged commit 480950f into nvaccess:master Jul 1, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jul 1, 2019

feerrenrut added a commit that referenced this pull request Jul 1, 2019

@bramd

This comment has been minimized.

Copy link
Contributor

commented Jul 1, 2019

@leonardder Thanks, now I can delete the appModule I wrote for this.

By the way, I think as it is now, that browse mode is also not triggered for content that is explicitly set to have a document role. For example, in some parts of VS Code it is nice to have browse mode by default, documentation/release notes/extension pages etc which are rendered as HTML documents.

@leonardder

This comment has been minimized.

Copy link
Collaborator Author

commented Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.