Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3: Update UIAutomationCore.dll comtypes module #9829

Merged
merged 1 commit into from Jul 3, 2019

Conversation

leonardder
Copy link
Collaborator

@leonardder leonardder commented Jun 27, 2019

Link to issue number:

None

Description of this pull request

We bundle a comtypes wrapper for the UIAutomation dll as we want to make sure that everyone has the same wrapper that supports the most recent version of Windows. The current wrapper was build with an older version of comtypes on Python 2.

I ran comtypes.client.GetModule("UIAutomationCore.dll") from a Python 3.7.3 interpretter with comtypes 1.1.7. As always, the order of definitions in the file has changed drastically.

Testing performed:

Tested that NVDA still starts and has access to UIA

Known issues with pull request:

NOne

Change log entry:

None

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Jun 27, 2019

@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Jun 27, 2019

AH, that info is only in the commit it seems

  • File version: 7.2.18362.1
  • Product version: 10.0.18362.1

@josephsl
Copy link
Collaborator

@josephsl josephsl commented Jun 27, 2019

@leonardder leonardder requested a review from feerrenrut Jul 1, 2019
@leonardder leonardder added this to In progress in Update NVDA to Python 3 via automation Jul 1, 2019
Update NVDA to Python 3 automation moved this from In progress to Reviewer approved Jul 3, 2019
@feerrenrut feerrenrut merged commit 5a0fb7f into nvaccess:threshold_py3_staging Jul 3, 2019
1 check passed
Update NVDA to Python 3 automation moved this from Reviewer approved to Done Jul 3, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants