Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3: Update py2exe to fix several issues #9856

Merged

Conversation

leonardder
Copy link
Collaborator

@leonardder leonardder commented Jul 2, 2019

Link to issue number:

Fixes #9813
Closes #9841
Fixes #9831

Summary of the issue:

During development of the threshold_py3_staging branch, some issues have been identified in py2exe. They have either been merged into upstream or have been considered stable by us.

Description of how this pull request fixes the issue:

  1. importing _ssl will no longer raise a module not found error
  2. Trace backs now contain proper paths
  3. win32wnet and pywintypes are excluded at build time, as they are not necessary for a running copy of NVDA
  4. Traceback paths are no longer stripped when NVDA is frozen, as before (in master)
  5. Updated the readme, removing some outdated stuff as well and added a distinction between run time and build time dependencies.

Testing performed:

Made sure that the steps to reproduce revealed the expected behaviour.
I will also test the try build again when it is finished.

Known issues with pull request:

None

Change log entry:

None

@leonardder leonardder requested a review from feerrenrut Jul 2, 2019
feerrenrut
feerrenrut previously approved these changes Jul 2, 2019
Copy link
Member

@feerrenrut feerrenrut left a comment

Thanks Leonard

@feerrenrut
Copy link
Member

@feerrenrut feerrenrut commented Jul 2, 2019

Though this build is failing, it looks like there might be an issue with py2exe.

@feerrenrut feerrenrut dismissed their stale review Jul 2, 2019

Build is failing.

@leonardder
Copy link
Collaborator Author

@leonardder leonardder commented Jul 2, 2019

Turns out I introduced this mistake after my last test of this, I know I'm bad, haha.
Fortunately, it was just a missing comma. Python is really weird in allowing concatenating strings "like " "this"

@leonardder leonardder requested a review from feerrenrut Jul 2, 2019
@feerrenrut feerrenrut added this to In progress in Update NVDA to Python 3 via automation Jul 3, 2019
Update NVDA to Python 3 automation moved this from In progress to Reviewer approved Jul 3, 2019
@feerrenrut feerrenrut merged commit 9812e7b into nvaccess:threshold_py3_staging Jul 3, 2019
1 check passed
Update NVDA to Python 3 automation moved this from Reviewer approved to Done Jul 3, 2019
@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jul 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants