Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Developer Guide re. tab completion (#9918) #9935

Merged
merged 3 commits into from Jul 19, 2019

Conversation

@JulienCochuyt
Copy link
Contributor

commented Jul 16, 2019

Link to issue number:

Fixes #9918

Summary of the issue:

In the Python console, the tab-completion is smarter with Python 3.

Description of how this pull request fixes the issue:

Document the new behavior in the Developer Guide.

Testing performed:

None.

Known issues with pull request:

Change log entry:

Section: Changes for developpers

The tab-completion in the Python console is now smarter. Refer to the Developer Guide for more details.

developerGuide.t2t Outdated Show resolved Hide resolved
developerGuide.t2t Outdated Show resolved Hide resolved
@XLTechie

This comment has been minimized.

Copy link

commented Jul 16, 2019

developerGuide.t2t Outdated Show resolved Hide resolved
developerGuide.t2t Outdated Show resolved Hide resolved
@JulienCochuyt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

@XLTechie, thank you for the feedback: I'm not a native English speaker.

@XLTechie

This comment has been minimized.

Copy link

commented Jul 16, 2019

developerGuide.t2t Outdated Show resolved Hide resolved
Fix-up (#9935 (comment))
Co-Authored-By: Luke Davis <8139760+XLTechie@users.noreply.github.com>
@JulienCochuyt

This comment has been minimized.

Copy link
Contributor Author

commented Jul 16, 2019

Sorry for the overlapping inline comments

No problem, feel free to further improve the proposed phrasing.

@XLTechie

This comment has been minimized.

Copy link

commented Jul 16, 2019

@feerrenrut feerrenrut changed the base branch from threshold_py3_staging to threshold Jul 19, 2019

@feerrenrut
Copy link
Contributor

left a comment

@feerrenrut feerrenrut merged commit 6c46739 into nvaccess:threshold Jul 19, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@nvaccessAuto nvaccessAuto added this to the 2019.3 milestone Jul 19, 2019

feerrenrut added a commit that referenced this pull request Jul 19, 2019

@JulienCochuyt JulienCochuyt deleted the accessolutions:i9918-developerGuide branch Jul 19, 2019

@josephsl josephsl referenced this pull request Jul 23, 2019
107 of 107 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.