Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Lint with flake8 #9958
Link to issue number:
Summary of the issue:
Code contributors regularly have to deal with ill-defined and inconsistently enforced code style requirements. Code reviewers spend much of their time reporting minor issues, time that would be better spent looking for architectural problems / product issues / logic errors.
Description of how this pull request fixes the issue:
Automate checking python style. The diff from new PR's will be tested for compliance with Flake8. The NVDA Python code already contains several inconsistent styles, so rather than try to match it I have tried to configure Flake8 to use the default style guidelines as much as possible.
This pr introduces two new SCons build targets:
Tested on appveyor:
Known issues with pull request:
Change log entry:
Changes for developers:
Ah, I had hoped that it was more descriptive. Never mind.
Aug 1, 2019
1 check passed
Coming back to this, I think it would be helpful to exclude checks for visual indents; although useful, it has drawbacks:
I'll create a new issue to discuss these further.