Skip to content

Reporting and focus sensitivty for remove actions #6

Closed
GianlucaApollaro opened this Issue Feb 21, 2015 · 8 comments

3 participants

@GianlucaApollaro

Hi,
in rea-access by pressing the delete key we could have the item, the selected track, or the selection deleted when we pressed the delete key. In osara this doesn't happen, even if the action says it does. I think this is a focus issue; a sighted user when puts the mouse on a track selects that track and the focus gets to the track, same with items. When I use the delete keys with osara I can delete only items, for deleting tracks or removing the selection I have to use specific actions,. So It turned out I had to map the delete key with shift, ctrl, and both to get the wanted result
Thanks

@jcsteh
jcsteh commented Feb 22, 2015

Yeah, I don't really understand REAPER's idea of focus. As you say, it seems to be somehow related to the mouse, which is unusual at best.

I think I'm going to have to handle each action separately. You say "actions", but you only mention delete. Specifically what actions do you require focus sensitivity for? There are quite a few, but I suspect some of them won't actually be relevant.

@jcsteh jcsteh added a commit that referenced this issue Feb 22, 2015
@jcsteh jcsteh When moving to a track or item, set REAPER's focus so that actions wh…
…ich depend on focus behave as expected.

To manage this, OSARA now requires REAPER 4.75 or later.
Re #6.
75c0b66
@jcsteh
jcsteh commented Feb 22, 2015

Actually, REAPER 4.75 allows us to set the focus using the API.

This covers tracks and items. However, you mention "the item, the selected track, or the selection". I assume you mean time selection? The REAPER actions only say "tracks/items/envelope points", not "time selection", so the REAPER actions can't (and shouldn't) touch the time selection. Was this your intention? If so, that'd require new actions.

@GianlucaApollaro
@jcsteh
jcsteh commented Feb 22, 2015

Fair enough. I'm happy to consider this; I can certainly see how it would be useful. I'm just pointing out that REAPER's in-built actions don't specify they will do this and I think overriding them to do so would be potentially confusing given that the description of the action doesn't mention time selection. That doesn't mean I can't create new actions, though.

Anyway, for now, this will at least work for tracks and items. I'll make a custom action to cover this plus time selection when I get some more time.

@GianlucaApollaro
@dgl1984
dgl1984 commented Mar 1, 2015

Agreed. This is also the case for an unsuccessful attempt to select or delete something. If I'm going through a project with several items, and think I have 1 or more selected, I'd like to know how many were deleted, cut, copied, pasted, etc. Even if 0 things ere deleted, that's good to know because it's happened before.

@jcsteh
jcsteh commented Mar 5, 2015

Please provide specific action names and exactly what you want reported. As I said, this has to be done specifically for each action. Please always be as specific as possible. Otherwise, we'll go back and forth for a few centuries trying to nail all the actions, since there are just so many in REAPER. Also, please keep separate issues in separate issue reports. Reporting this kind of information is a separate issue to focus sensitivity, yet they're both being discussed here. Thanks.

@jcsteh jcsteh changed the title from Actions depending on focus to Reporting and focus sensitivty for remove actions Mar 9, 2015
@jcsteh jcsteh added a commit that closed this issue Mar 9, 2015
@jcsteh jcsteh Changes related to reporting and focus sensitivty for remove actions.
- Report what was removed for the actions: Track: Remove tracks, Item: Remove items, Time selection: Remove contents of time selection (moving later items).
- New action: OSARA: Remove items/tracks/contents of time selection (depending on focus). This is useful because REAPER's in-built focus-dependent remove action doesn't cover time selection.

Fixes #6.
5dbc6a9
@jcsteh jcsteh closed this in 5dbc6a9 Mar 9, 2015
@jcsteh
jcsteh commented Mar 9, 2015

Please file new issues for other actions/groups of actions. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.