Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addressed Issue #210 #216

Merged
merged 1 commit into from May 23, 2015

Conversation

Projects
None yet
2 participants
@diezcami
Copy link
Contributor

commented May 23, 2015

Hi, I wanted to address the issue regarding the open command for URL's not being recognised by fuck.
The code I provided works for the more popular domain extensions and the tests. However, I actually originally wanted to do something along these lines:

def match(command, settings):
    #Unpopular Extensions
    ext = ['.ly', '.se', '.io', '.edu']
    return (command.script.startswith ('open')
            and 'does not exist' in command.stderr
            and ('http' in command.stderr
            or any(e in command.script for e in ext)))

I couldn't get the any syntax or anything that involves command.stderr to work with my code while testing though. It'd be great if you could shed some light on this issue for me so I could edit the code :) Thanks!

@nvbn

This comment has been minimized.

Copy link
Owner

commented May 23, 2015

Thanks!

nvbn added a commit that referenced this pull request May 23, 2015

@nvbn nvbn merged commit 910e6f4 into nvbn:master May 23, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

nvbn added a commit that referenced this pull request May 23, 2015

amtrivedi91 added a commit to amtrivedi91/thefuck that referenced this pull request Aug 31, 2016

amtrivedi91 added a commit to amtrivedi91/thefuck that referenced this pull request Aug 31, 2016

amtrivedi91 added a commit to amtrivedi91/thefuck that referenced this pull request Aug 31, 2016

amtrivedi91 added a commit to amtrivedi91/thefuck that referenced this pull request Aug 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.