Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browse mode is incorrectly shown #13

Closed
nishimotz opened this issue May 3, 2019 · 4 comments
Closed

browse mode is incorrectly shown #13

nishimotz opened this issue May 3, 2019 · 4 comments

Comments

@nishimotz
Copy link
Member

@nishimotz nishimotz commented May 3, 2019

When "Enable browse mode on page load" is turned off and a web browser window is focused, FH shows the red rectangle, which incorrectly shows the browse mode is active.

nishimotz added a commit that referenced this issue May 3, 2019
@nishimotz
Copy link
Member Author

@nishimotz nishimotz commented May 4, 2019

Since 6.0, isPassThroughMode() defaults to True rather than False, so the behavior regarding this is more consistent than the previous versions.

@nishimotz nishimotz closed this May 4, 2019
@britechguy
Copy link

@britechguy britechguy commented May 28, 2019

See the topic: Has anyone else noticed a change in the behavior of Focus Highlight? on the NVDA group on Groups.io.

I am now having very weird behavior where Focus Highlight appears to be "stuck in focus mode" when browse mode should be available. File Explorer being the best example of this. I am shown in focus mode when traversing the list of files and folders, but am not actively renaming one. Also, and I do not know if this is related, when I am trying to do selection of multiple files using CTRL+Spacebar to get individual files the "unselected" state is announced correctly when I land on it, but hitting spacebar announces "space" rather than "selected."

@nishimotz
Copy link
Member Author

@nishimotz nishimotz commented May 28, 2019

The first thing is an intentional change in 6.0.
"Enable browse mode on page load" option will be added in NVDA 2019.2.
With this option turned off, and a web browser is just activated, Focus Highlight should show the blue rectangle, rather than the red box.

An app which does not support browse mode is always "passthrough mode," which corresponds to the focus mode.
When browse mode is turned off, a web browser app is in passthrough mode internally as well.
In the previous versions of Focus Highlight did not consistently handle the passthrough mode.

The second thing you mentioned seems not related to this add-on.

nishimotz added a commit that referenced this issue Jun 6, 2019
nishimotz added a commit that referenced this issue Jun 6, 2019
nishimotz added a commit that referenced this issue Jun 6, 2019
nishimotz added a commit that referenced this issue Jun 6, 2019
nishimotz added a commit that referenced this issue Jun 9, 2019
@nishimotz
Copy link
Member Author

@nishimotz nishimotz commented Jun 10, 2019

Version 6.1 is out.
https://github.com/nvdajp/focusHighlight/releases/tag/6.1

If you are not comfortable with this issue, please use NVDA Settings dialog Focus Highlight category and turn off "Make focus mode the default" option.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants