New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename '.v' files to '.vx', '.vpl', or similar. #48

Closed
josahe opened this Issue Nov 8, 2017 · 2 comments

Comments

Projects
None yet
2 participants
@josahe

josahe commented Nov 8, 2017

The file NV_NVDLA_partition_o.v has been mistakenly committed using (for example) #ifdef rather than `ifdef.

Don't you run design checks before committing RTL updates?

@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 8, 2017

Member

Hi @josahe -- you're not the first one to be confused by this, to be sure! We added a layer that runs through the C preprocessor first. @xalogic-linus noted this in #45, too. Make sure that you build with bin/tmake -- don't use the .v files as is. This does seem to be somewhat confusing, though, so we'll look into renaming files that need preprocessing to .vx.

We do, in fact, have a continuous integration flow; internally, we're using Jenkins for this, but we're working in the background on figuring out how to have an external CI flow that doesn't need a VCS license. Stay tuned on that one.

Member

jwise commented Nov 8, 2017

Hi @josahe -- you're not the first one to be confused by this, to be sure! We added a layer that runs through the C preprocessor first. @xalogic-linus noted this in #45, too. Make sure that you build with bin/tmake -- don't use the .v files as is. This does seem to be somewhat confusing, though, so we'll look into renaming files that need preprocessing to .vx.

We do, in fact, have a continuous integration flow; internally, we're using Jenkins for this, but we're working in the background on figuring out how to have an external CI flow that doesn't need a VCS license. Stay tuned on that one.

@jwise jwise changed the title from Commit 11bc4c5 breaks vmod/nvdla/top/NV_NVDLA_partition_o.v with syntax errors to Rename '.v' files to '.vx', '.vpl', or similar. Nov 8, 2017

@josahe

This comment has been minimized.

Show comment
Hide comment
@josahe

josahe Nov 9, 2017

Sorry for not seeing the previously raised issue.

I actually pulled the latest commits without revisiting the documentation so failed to notice the new build flow (everything had been previously working with my own flows).

I've run the flow and I'm back up and running. Thanks!

josahe commented Nov 9, 2017

Sorry for not seeing the previously raised issue.

I actually pulled the latest commits without revisiting the documentation so failed to notice the new build flow (everything had been previously working with my own flows).

I've run the flow and I'm back up and running. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment