New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed define for @array, as required in current perl #47

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@cliffgold
Contributor

cliffgold commented Nov 8, 2017

I tried to get to perl 5.8.8, but was not successful in Ubuntu. Still got:

Can't use 'defined(@array)' (Maybe you should just omit the defined()?) at ./tools/bin/tmake line 39.

Took their advice. Checked, "verif" is pushed if no -build option.

@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 8, 2017

Member

I'll check if this change works on the version of Perl we're using on the farm in the morning. Thanks!

Member

jwise commented Nov 8, 2017

I'll check if this change works on the version of Perl we're using on the farm in the morning. Thanks!

@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 9, 2017

Member

Ok, we took a look earlier today, and indeed, this is the right thing to do -- in fact, it turns out that we also have this change in our internal staging repo, so I'll hold off on merging this until we get our latest pushed out.

Thanks for your interest and for the contribution! We appreciate the sharp eyes!

Member

jwise commented Nov 9, 2017

Ok, we took a look earlier today, and indeed, this is the right thing to do -- in fact, it turns out that we also have this change in our internal staging repo, so I'll hold off on merging this until we get our latest pushed out.

Thanks for your interest and for the contribution! We appreciate the sharp eyes!

@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 18, 2017

Member

I haven't forgotten about this. We're working on a branch into the 'configurable' branch, which will diverge from the 'dlav1' branch; I intend to integrate this into the dlav1 branch once I've got that forked off and set up properly. Thanks for your patience!

Member

jwise commented Nov 18, 2017

I haven't forgotten about this. We're working on a branch into the 'configurable' branch, which will diverge from the 'dlav1' branch; I intend to integrate this into the dlav1 branch once I've got that forked off and set up properly. Thanks for your patience!

@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 21, 2017

Member

Ok, I have pulled this into the 'nvdlav1' branch, which is the new branch for the "non-configurable" NVDLA release that we're working on. Thanks!

Member

jwise commented Nov 21, 2017

Ok, I have pulled this into the 'nvdlav1' branch, which is the new branch for the "non-configurable" NVDLA release that we're working on. Thanks!

@jwise jwise closed this Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment