New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simulations work on Vivado xsim. Tested on Vivado 2017.1 #49

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
2 participants
@xalogic-linus
Contributor

xalogic-linus commented Nov 10, 2017

Created a new directory sim_vivado in order not to mess up with the existing VCS environment.
TB files and RTL needed some ifdefs to be compatible with Vivado XSIM.

  • $value$plugargs compatibility
  • $sformatf not supported by Vivado

TODO:

  • about 100+ RTL files in VLIB requires more ifdefs for $value$plusargs. This seems to not affect basic simulations. I will work on these next.
@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 10, 2017

Member

This looks great. Let me check with our legal team if we need you to sign a contributor license agreement to merge this. Is this done on behalf of XaLogic, or was this done entirely in your own personal capacity? If the former, can you confirm that you have permission to license this under the Open NVDLA License, and that you do in fact do so?

Member

jwise commented Nov 10, 2017

This looks great. Let me check with our legal team if we need you to sign a contributor license agreement to merge this. Is this done on behalf of XaLogic, or was this done entirely in your own personal capacity? If the former, can you confirm that you have permission to license this under the Open NVDLA License, and that you do in fact do so?

@xalogic-linus

This comment has been minimized.

Show comment
Hide comment
@xalogic-linus

xalogic-linus Nov 10, 2017

Contributor

I would like to address this privately through email. Can you provide me an email I should send my response to?

Contributor

xalogic-linus commented Nov 10, 2017

I would like to address this privately through email. Can you provide me an email I should send my response to?

@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 10, 2017

Member

Yes, you can send us mail at nvdla@nvidia.com.

Member

jwise commented Nov 10, 2017

Yes, you can send us mail at nvdla@nvidia.com.

@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 18, 2017

Member

I haven't forgotten about this. We're working on a branch into the 'configurable' branch, which will diverge from the 'dlav1' branch; I intend to integrate this into the dlav1 branch once I've got that forked off and set up properly. Thanks for your patience!

Member

jwise commented Nov 18, 2017

I haven't forgotten about this. We're working on a branch into the 'configurable' branch, which will diverge from the 'dlav1' branch; I intend to integrate this into the dlav1 branch once I've got that forked off and set up properly. Thanks for your patience!

@xalogic-linus

This comment has been minimized.

Show comment
Hide comment
@xalogic-linus

xalogic-linus Nov 18, 2017

Contributor
Contributor

xalogic-linus commented Nov 18, 2017

Show outdated Hide outdated vmod/vlibs/RANDFUNC.vlib Outdated
@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Nov 21, 2017

Member

Ok, I have pulled this into the 'nvdlav1' branch, which is the new branch for the "non-configurable" NVDLA release that we're working on. Thanks!

Member

jwise commented Nov 21, 2017

Ok, I have pulled this into the 'nvdlav1' branch, which is the new branch for the "non-configurable" NVDLA release that we're working on. Thanks!

@jwise jwise closed this Nov 21, 2017

@jwise

This comment has been minimized.

Show comment
Hide comment
@jwise

jwise Mar 14, 2018

Member

FYI -- I don't have an Xilinx license to test this in a backport to the 'configurable' branch (coming in the next week or two), so this change isn't going to make it into the first version of that. (Additionally, the testbench has been substantially revamped since then.) But, I think that there should soon be some Xilinx synthesis compatibility changes in preparation to run on Amazon EC2.

Member

jwise commented Mar 14, 2018

FYI -- I don't have an Xilinx license to test this in a backport to the 'configurable' branch (coming in the next week or two), so this change isn't going to make it into the first version of that. (Additionally, the testbench has been substantially revamped since then.) But, I think that there should soon be some Xilinx synthesis compatibility changes in preparation to run on Amazon EC2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment