Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Broken links in api documentation in rossmann notebook #28

Closed
benfred opened this issue Jun 4, 2020 · 1 comment
Closed

[DOC] Broken links in api documentation in rossmann notebook #28

benfred opened this issue Jun 4, 2020 · 1 comment
Labels
documentation Improvements or additions to documentation

Comments

@benfred
Copy link
Member

benfred commented Jun 4, 2020

Issue by benfred
Wednesday May 13, 2020 at 21:00 GMT
Originally opened as https://github.com/rapidsai/recsys/issues/126


Rossmann Store Sales Example; http://10.33.227.156:12800/examples/rossmann-store-sales-preproc.ipynb cannot be found

This might be hard to fix because of how we're rendering the notebook with nbsphinx . See https://github.com/rapidsai/recsys/pull/115 for how we fixed links in the README

@benfred benfred added the documentation Improvements or additions to documentation label Jun 5, 2020
@benfred
Copy link
Member Author

benfred commented May 4, 2021

this is fixed - and we've updated our build process to fail PR's that have broken links like this in notebooks

@benfred benfred closed this as completed May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant