Implement Standard Schema spec#1213
Merged
Merged
Conversation
`/test/core/Result.test.ts` is the same set of tests
nvie
reviewed
Feb 3, 2025
Owner
nvie
left a comment
nvie
left a comment
There was a problem hiding this comment.
This is amazing, @marcbouchenoire — thanks for the contribution 😍 ! I've been wanting to add this for a while, but just hadn't done so. I'd like to make the error reporting play a bit nicer too (closer to the structure that's intended) before we merge it, but the rest looks good to me already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the Standard Schema spec.