Skip to content
Browse files

Replace 'review' status by 'test'.

  • Loading branch information...
1 parent fe0483a commit 99ff47d1417eae0f274c598c75af3ae23863a1a2 @nvie committed
Showing with 12 additions and 12 deletions.
  1. +1 −1 README
  2. +6 −6 bin/it
  3. +4 −4 lib/gitit.py
  4. +1 −1 lib/ticket.py
View
2 README
@@ -30,7 +30,7 @@ Then, typical workflow with git-it is:
it leave <ticket-id>
- Close/reopen existing tickets:
- it review <ticket-id>
+ it test <ticket-id>
it close <ticket-id>
it fix <ticket-id>
it reject <ticket-id>
View
12 bin/it
@@ -30,7 +30,7 @@ def usage():
print ' it from your INBOX.'
print ''
print 'Changing status:'
- print ' review Mark a ticket as in-review.'
+ print ' test Mark a ticket as to-test.'
print ' close Mark a ticket as closed.'
print ' fix Mark a ticket as fixed.'
print ' reject Mark a ticket as rejected.'
@@ -63,7 +63,7 @@ if len(params) == 0:
# Valid subcommand?
subcmd = params[0]
del params[0]
-if not subcmd in [ 'init', 'list', 'show', 'new', 'edit', 'mv', 'rm', 'reopen', 'close', 'fix', 'reject', 'review', 'take', 'leave', 'sync' ]:
+if not subcmd in [ 'init', 'list', 'show', 'new', 'edit', 'mv', 'rm', 'reopen', 'close', 'fix', 'reject', 'test', 'take', 'leave', 'sync' ]:
log.printerr('Unknown subcommand \'%s\'.' % subcmd)
usage()
sys.exit(1)
@@ -75,7 +75,7 @@ if subcmd == 'init':
elif subcmd == 'new':
g.new()
elif subcmd == 'list':
- types = ['open', 'review']
+ types = ['open', 'test']
if len(params) > 0:
if params[0] == '-a':
types += [ 'closed', 'fixed', 'rejected' ]
@@ -125,11 +125,11 @@ elif subcmd == 'reject':
log.printerr('usage: it close <id>')
sys.exit(1)
g.finish_ticket(params[0], 'rejected')
-elif subcmd == 'review':
+elif subcmd == 'test':
if len(params) != 1:
- log.printerr('usage: it review <id>')
+ log.printerr('usage: it test <id>')
sys.exit(1)
- g.finish_ticket(params[0], 'review')
+ g.finish_ticket(params[0], 'test')
elif subcmd == 'reopen':
if len(params) != 1:
log.printerr('usage: it reopen <id>')
View
8 lib/gitit.py
@@ -297,7 +297,7 @@ def __print_ticket_rows(self, rel, tickets, show_types, show_progress_bar, annot
width = int(width)
total = sum([t.weight for t in tickets if t.status != 'rejected']) * 1.0
- done = sum([t.weight for t in tickets if t.status not in ['open', 'rejected', 'review']]) * 1.0
+ done = sum([t.weight for t in tickets if t.status not in ['open', 'rejected', 'test']]) * 1.0
release_line = colors.colors['red-on-white'] + '%-16s' % rel + \
colors.colors['default']
@@ -354,7 +354,7 @@ def __print_ticket_rows(self, rel, tickets, show_types, show_progress_bar, annot
return print_count
- def list(self, show_types = ['open', 'review'], releases_filter = []):
+ def list(self, show_types = ['open', 'test'], releases_filter = []):
self.require_itdb()
releasedirs = filter(lambda x: x[1] == 'tree', git.tree(it.ITDB_BRANCH + \
':' + it.TICKET_DIR))
@@ -391,7 +391,7 @@ def list(self, show_types = ['open', 'review'], releases_filter = []):
print_count += self.__print_ticket_rows(rel, tickets, show_types, True, True)
- print_count += self.__print_ticket_rows('INBOX', inbox, (show_types == ['open','review']) and ['open'] or show_types, False, False)
+ print_count += self.__print_ticket_rows('INBOX', inbox, (show_types == ['open','test']) and ['open'] or show_types, False, False)
if print_count == 0:
print 'use the -a flag to show all tickets'
@@ -426,7 +426,7 @@ def get_ticket(self, sha):
def finish_ticket(self, sha, new_status):
i, _, fullsha, match = self.get_ticket(sha)
sha7 = misc.chop(fullsha, 7)
- if i.status not in ['open', 'review']:
+ if i.status not in ['open', 'test']:
log.printerr('ticket \'%s\' already %s' % (sha7, i.status))
sys.exit(1)
View
2 lib/ticket.py
@@ -164,7 +164,7 @@ class Ticket:
prio_names = [ 'high', 'med', 'low' ]
prio_colors = { 'high': 'red-on-white', 'med': 'yellow-on-white', 'low': 'white' }
status_colors = { 'open': 'bold', \
- 'review': 'bold', \
+ 'test': 'bold', \
'closed': 'default', \
'rejected': 'red-on-white', \
'fixed': 'green-on-white' }

0 comments on commit 99ff47d

Please sign in to comment.
Something went wrong with that request. Please try again.