Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Usage of positional parameters requires to eval ${FLAGS_ARGV} #232

Open
wants to merge 1 commit into from

1 participant

@baby-gnu

The "eval set" in function call does not propagate to the caller.

The following does not works:

git flow feature start -F great-thing nvie/develop
fatal: git checkout: updating paths is incompatible with switching branches.
Did you intend to checkout 'great-thing' which can not be resolved as commit?
Could not create feature branch 'feature/great-thing'

With my patch:

git flow feature start -F great-thing nvie/develop
Branch feature/great-thing set up to track remote branch develop from nvie.
Switched to a new branch 'feature/great-thing'

Summary of actions:
- A new branch 'feature/great-thing' was created, based on 'nvie/develop'
- You are now on branch 'feature/great-thing'

Now, start committing on your feature. When done, use:

     git flow feature finish great-thing
Daniel Dehennin Usage of positional parameters requires to eval ${FLAGS_ARGV}
The "eval set" in function call does not propagate to the caller.

* git-flow-feature (cmd_start): Eval ${FLAGS_ARGV} as positional
  parameters.

* git-flow-hotfix (cmd_start): Ditoo.

* git-flow-release (cmd_start): Ditoo
0e4c831
@baby-gnu

It's already fixed in Peter van der Does fork with several other improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Jul 8, 2012
  1. Usage of positional parameters requires to eval ${FLAGS_ARGV}

    Daniel Dehennin authored
    The "eval set" in function call does not propagate to the caller.
    
    * git-flow-feature (cmd_start): Eval ${FLAGS_ARGV} as positional
      parameters.
    
    * git-flow-hotfix (cmd_start): Ditoo.
    
    * git-flow-release (cmd_start): Ditoo
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 0 deletions.
  1. +1 −0  git-flow-feature
  2. +1 −0  git-flow-hotfix
  3. +1 −0  git-flow-release
View
1  git-flow-feature
@@ -194,6 +194,7 @@ parse_remote_name() {
cmd_start() {
DEFINE_boolean fetch false 'fetch from origin before performing local operation' F
parse_args "$@"
+ eval set -- "${FLAGS_ARGV}"
BASE=${2:-$DEVELOP_BRANCH}
require_name_arg
View
1  git-flow-hotfix
@@ -156,6 +156,7 @@ require_no_existing_hotfix_branches() {
cmd_start() {
DEFINE_boolean fetch false "fetch from $ORIGIN before performing finish" F
parse_args "$@"
+ eval set -- "${FLAGS_ARGV}"
BASE=${2:-$MASTER_BRANCH}
require_version_arg
require_base_is_on_master
View
1  git-flow-release
@@ -152,6 +152,7 @@ require_no_existing_release_branches() {
cmd_start() {
DEFINE_boolean fetch false "fetch from $ORIGIN before performing finish" F
parse_args "$@"
+ eval set -- "${FLAGS_ARGV}"
BASE=${2:-$DEVELOP_BRANCH}
require_version_arg
require_base_is_on_develop
Something went wrong with that request. Please try again.