Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible bash path via /usr/bin/env #383

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

tpltnt
Copy link

@tpltnt tpltnt commented Oct 26, 2014

Hi nvie,

sometimes bash is not located at /bin/bash. This patch makes the installer more flexible by determining the path for bash dynamically.

Cheers,
tpltnt

sometimes bash is not at /bin/bash
@ssaavedra
Copy link

Why should env's location be considered more stable than bash's?
If your bash is not there you can always invoke the installer via bash <file>.

@tpltnt
Copy link
Author

tpltnt commented Feb 11, 2015

Yes I could do it, but why then have the shebang line in the first place? I mean you could also run the script now as an argument to bash. My change is meant to have a convenient installer on all systems, not just Linux. On FreeBSD bash is located at /usr/local/bin/bash and not /bin/bash. Why do you want to keep up inconveniences for non-Linux systems (given that we have computers to automatically address them)?

@ssaavedra
Copy link

You are definitely right; I didn't know env would have a more standard location than bash, I just wanted a bit of context on why this was important :)

And the only overhead is probably a further execv call, which is not that much of a deal anyway.

@fspreng
Copy link

fspreng commented Feb 12, 2015

Many thanks for your contribution @tpltnt. It would be great to have a PR addressing this issue also for the ITM Gitflow fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants