Don't run lrem directly if we have a pipeline #770

Merged
merged 1 commit into from Dec 8, 2016

Projects

None yet

3 participants

@mtdewulf
Contributor
mtdewulf commented Dec 8, 2016

Not sure if this is correct, but I was looking through the code and noticed that if a pipeline is passed to Queue.cancel we add an lrem call to the pipeline and then also call lrem immediately on the connection. I think we just want to add it to the pipeline in that case?

@coveralls
coveralls commented Dec 8, 2016 edited

Coverage Status

Coverage increased (+0.008%) to 86.026% when pulling 9e8922a on mtdewulf:queue-cancel-pipeline-fix into 6721463 on nvie:master.

@coveralls

Coverage Status

Coverage increased (+0.008%) to 86.026% when pulling 9e8922a on mtdewulf:queue-cancel-pipeline-fix into 6721463 on nvie:master.

@selwin
Collaborator
selwin commented Dec 8, 2016

Your observation seems to be correct. Thanks!

@selwin selwin merged commit 4fc032b into nvie:master Dec 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment