Rails Completed log improvement #130

Closed
zedtux opened this Issue Mar 16, 2015 · 4 comments

Comments

Projects
None yet
2 participants
@zedtux

zedtux commented Mar 16, 2015

This issue is an improvement proposal.

When a Rails application is running and writting logs, there is the famous line

Completed 200 OK in 247ms (Views: 86.0ms | ActiveRecord: 110.9ms)

This line could be improved by adding Nobrainer after ActiveRecord like so:

Completed 200 OK in 277ms (Views: 86.0ms | ActiveRecord: 110.9ms | Nobrainer: 30ms)
@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Mar 20, 2015

@nviennot can you please tell if this looks good idea for you ?

zedtux commented Mar 20, 2015

@nviennot can you please tell if this looks good idea for you ?

@nviennot

This comment has been minimized.

Show comment
Hide comment
@nviennot

nviennot Mar 20, 2015

Owner

Yes it's a good idea, I haven't got the time to implement it yet :)

Owner

nviennot commented Mar 20, 2015

Yes it's a good idea, I haven't got the time to implement it yet :)

@nviennot nviennot closed this in 5336e0a Apr 12, 2015

@nviennot

This comment has been minimized.

Show comment
Hide comment
@nviennot

nviennot Apr 12, 2015

Owner

Done.

You'll get a break down that accounts for read and write queries separately:

Completed 200 OK in 151ms (Views: 121.5ms | NoBrainer: 29.4ms (read), 15.3ms (write))
Owner

nviennot commented Apr 12, 2015

Done.

You'll get a break down that accounts for read and write queries separately:

Completed 200 OK in 151ms (Views: 121.5ms | NoBrainer: 29.4ms (read), 15.3ms (write))
@zedtux

This comment has been minimized.

Show comment
Hide comment
@zedtux

zedtux Apr 14, 2015

Awesome !! I will give it a try as soon as possible. The way you did it rocks !

zedtux commented Apr 14, 2015

Awesome !! I will give it a try as soon as possible. The way you did it rocks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment