Fix Rails 5 deprecation #209

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@jeroenvisser101
Contributor

jeroenvisser101 commented Jun 1, 2016

Using ActiveSupport::Reloader instead of ActionDispatch::Reloader to be
ready when Rails 5 hits (and to prevent it from breaking when 5.1 comes
out).

DEPRECATION WARNING: to_prepare is deprecated and will be removed from Rails 5.1
(use ActiveSupport::Reloader.to_prepare instead) (called from block in <class:Railtie> at /path/to/lib/no_brainer/railtie.rb:29)
Fix Rails 5 deprecation
Using ActiveSupport::Reloader instead of ActionDispatch::Reloader to be
ready when Rails 5 hits (and to prevent it from breaking when 5.1 comes
out).

DEPRECATION WARNING: to_prepare is deprecated and will be removed from
Rails 5.1 (use ActiveSupport::Reloader.to_prepare instead)
(called from block in <class:Railtie> at /path/to/lib/no_brainer/railtie.rb:29)
@jeroenvisser101

This comment has been minimized.

Show comment
Hide comment
@jeroenvisser101

jeroenvisser101 Jun 1, 2016

Contributor

It seems that JRuby failing isn't connected to this PR.

Contributor

jeroenvisser101 commented Jun 1, 2016

It seems that JRuby failing isn't connected to this PR.

@jeroenvisser101

This comment has been minimized.

Show comment
Hide comment
@jeroenvisser101

jeroenvisser101 Jun 2, 2016

Contributor

Fixes #205

Contributor

jeroenvisser101 commented Jun 2, 2016

Fixes #205

@jeroenvisser101

This comment has been minimized.

Show comment
Hide comment
@jeroenvisser101

jeroenvisser101 Jun 2, 2016

Contributor

@nviennot it seems to break due to the secret key being empty on jruby, not sure about that. Do you mind checking this out?

Contributor

jeroenvisser101 commented Jun 2, 2016

@nviennot it seems to break due to the secret key being empty on jruby, not sure about that. Do you mind checking this out?

@jeroenvisser101

This comment has been minimized.

Show comment
Hide comment
@jeroenvisser101

jeroenvisser101 Jun 2, 2016

Contributor

There still seem to be some issues. In Rails 5, I keep getting the 'already registered and partially loaded' error, which I think is due to concurrent-ruby.

Contributor

jeroenvisser101 commented Jun 2, 2016

There still seem to be some issues. In Rails 5, I keep getting the 'already registered and partially loaded' error, which I think is due to concurrent-ruby.

@nviennot nviennot closed this in e343787 Jun 5, 2016

@nviennot

This comment has been minimized.

Show comment
Hide comment
@nviennot

nviennot Jun 5, 2016

Owner

Hi Jeroen :)

  • I removed jruby from travis-ci (even though the tests are running just fine locally). I don't think I want to troubleshoot the SSL erorrs it gives.
  • Merged the pull request
  • I can't reproduce the "already registered and partially loaded" error. If you want to open a new issue with some code to reproduce it, that'd be great :)

Thanks,
Nico

Owner

nviennot commented Jun 5, 2016

Hi Jeroen :)

  • I removed jruby from travis-ci (even though the tests are running just fine locally). I don't think I want to troubleshoot the SSL erorrs it gives.
  • Merged the pull request
  • I can't reproduce the "already registered and partially loaded" error. If you want to open a new issue with some code to reproduce it, that'd be great :)

Thanks,
Nico

@jeroenvisser101

This comment has been minimized.

Show comment
Hide comment
@jeroenvisser101

jeroenvisser101 Jun 5, 2016

Contributor

@nviennot thanks for merging! Will see if I can get some code working next week. I've got a fork up that resolves the issue for me (not sure if it breaks other things though). If you want, you can have a look here.

Contributor

jeroenvisser101 commented Jun 5, 2016

@nviennot thanks for merging! Will see if I can get some code working next week. I've got a fork up that resolves the issue for me (not sure if it breaks other things though). If you want, you can have a look here.

@nviennot

This comment has been minimized.

Show comment
Hide comment
@nviennot

nviennot Jun 5, 2016

Owner

Thank you for the PR!

I'd be interesting in seeing the code that triggers the "partially loaded" error.

Owner

nviennot commented Jun 5, 2016

Thank you for the PR!

I'd be interesting in seeing the code that triggers the "partially loaded" error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment