Skip to content

Conversation

@johnf
Copy link
Contributor

@johnf johnf commented Aug 4, 2022

Add support to hide files by comparing to glob of full path

@johnf johnf changed the base branch from v2.x to main August 4, 2022 08:41
@johnf johnf force-pushed the hide_by_pattern_path branch from 4c6fc38 to 49475f8 Compare August 4, 2022 21:31
@johnf johnf force-pushed the hide_by_pattern_path branch from 49475f8 to 33e1cb0 Compare August 14, 2022 10:06
@johnf johnf force-pushed the hide_by_pattern_path branch from 33e1cb0 to 923eec2 Compare August 14, 2022 10:07
@johnf
Copy link
Contributor Author

johnf commented Aug 14, 2022

@cseickel I've made the changes as suggested.
This works fine on Unix systems
In theory it will work fine on Windows systems but I'm not sure the glob library actually works on windows systems
When I was printing out the glob patterns it looks like it eats up the backslashed

@codecov
Copy link

codecov bot commented Aug 14, 2022

Codecov Report

Merging #468 (f7e4699) into main (ad3a1d6) will increase coverage by 0.05%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #468      +/-   ##
==========================================
+ Coverage   52.56%   52.61%   +0.05%     
==========================================
  Files          46       46              
  Lines        5724     5726       +2     
==========================================
+ Hits         3009     3013       +4     
+ Misses       2715     2713       -2     
Impacted Files Coverage Δ
lua/neo-tree/defaults.lua 96.87% <ø> (ø)
lua/neo-tree/sources/common/file-items.lua 67.40% <0.00%> (-1.02%) ⬇️
lua/neo-tree/utils.lua 49.72% <0.00%> (+0.27%) ⬆️
lua/neo-tree/sources/filesystem/init.lua 65.67% <0.00%> (+1.27%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cseickel
Copy link
Contributor

In theory it will work fine on Windows systems but I'm not sure the glob library actually works on windows systems
When I was printing out the glob patterns it looks like it eats up the backslashed

I think it should work if they use double backslash to escape it. Windows users are used to that.

Copy link
Contributor

@cseickel cseickel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, thanks!

@cseickel cseickel merged commit 16ae520 into nvim-neo-tree:main Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants