Repository navigation
Feature: insert issue reference on <CR> - #33
Merged
Merged
Conversation
Collaborator
|
Hi @cljoly I agree that it would be more convenient. |
Contributor
Author
|
Hi @sbulav , I'll look into rebasing and fixing conflicts in the next few days. Thanks for your work on this project! |
Contributor
Author
|
Alright, it works on my computer, this should be ready if you wanna give it a try. |
sbulav
requested changes
Jan 17, 2022
sbulav
left a comment
sbulav
left a comment
Collaborator
There was a problem hiding this comment.
Overall looks good, but please stick with the same approach for inserting text as we use for other actions.
Currently, `<CR>` is set to “close Telescope”. There is already a generic “cancel” mapping for that. I find more useful to just insert the selected issue in the buffer we come from. This allows to insert references to GitHub issues in commit messages, code comments…
Collaborator
|
Merged. Thanks for your contribution! |
Contributor
Author
|
Awesome, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently,
<CR>is set to “close Telescope”. There is already ageneric “cancel” mapping for that. I find more useful to just insert the
selected issue in the buffer we come from.
This allows to insert references to GitHub issues in commit messages,
code comments…