Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: insert issue reference on <CR> #33

Merged
merged 1 commit into from Jan 18, 2022

Conversation

cljoly
Copy link
Contributor

@cljoly cljoly commented Jan 3, 2022

Currently, <CR> is set to “close Telescope”. There is already a
generic “cancel” mapping for that. I find more useful to just insert the
selected issue in the buffer we come from.

This allows to insert references to GitHub issues in commit messages,
code comments…

@sbulav
Copy link
Collaborator

sbulav commented Jan 10, 2022

Hi @cljoly

I agree that it would be more convenient.
I've merged my fork with a lot of changes so please resolve conflicts before I can merge your PR.

@cljoly
Copy link
Contributor Author

cljoly commented Jan 11, 2022

Hi @sbulav , I'll look into rebasing and fixing conflicts in the next few days. Thanks for your work on this project!

@cljoly
Copy link
Contributor Author

cljoly commented Jan 14, 2022

Alright, it works on my computer, this should be ready if you wanna give it a try.

Copy link
Collaborator

@sbulav sbulav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, but please stick with the same approach for inserting text as we use for other actions.

lua/telescope/_extensions/gh_actions.lua Outdated Show resolved Hide resolved
Currently, `<CR>` is set to “close Telescope”. There is already a
generic “cancel” mapping for that. I find more useful to just insert the
selected issue in the buffer we come from.

This allows to insert references to GitHub issues in commit messages,
code comments…
@sbulav
Copy link
Collaborator

sbulav commented Jan 18, 2022

Merged. Thanks for your contribution!

@sbulav sbulav merged commit e4783c7 into nvim-telescope:master Jan 18, 2022
@cljoly
Copy link
Contributor Author

cljoly commented Jan 19, 2022

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants