Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow user to explicitly opt out of nvm adding the source string #1804

Merged
merged 1 commit into from Jun 5, 2018

Conversation

spikegrobstein
Copy link
Contributor

this is done by checking if the user supplies PROFILE=/dev/null when
running install.sh, the nvm_detect_profile function will not output
any strings, causing nvm_do_install to skip adding SOURCE_STR.

tests are included.

…e source string

this is done by checking if the user supplies `PROFILE=/dev/null` when running `install.sh`, the `nvm_detect_profile` function will not output any strings, causing `nvm_do_install` to skip adding `SOURCE_STR`.
@ljharb
Copy link
Member

ljharb commented May 3, 2018

What's the use case here where you want the install script but you don't want what it does?

@spikegrobstein
Copy link
Contributor Author

We've got an automated install process for setting up workstations that uses the installer script to ensure that nvm is both installed and is the most recent version. We have our own code that gets sourced that loads nvm.sh, but install script adds it to the main shell init file, which causes it to be sourced twice.

@ljharb ljharb added the installing nvm Problems installing nvm itself label Jun 5, 2018
@ljharb ljharb merged commit 9854928 into nvm-sh:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
installing nvm Problems installing nvm itself
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants