Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libssl-dev to Docker image #1835

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@sturman
Copy link

commented Jun 13, 2018

No description provided.

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2018

Why?

@sturman

This comment has been minimized.

Copy link
Author

commented Jun 13, 2018

because installation of Node.js v0.6.20 in Docker failed due to missing OpenSSL. Unfortunately, I don't have log now

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Jun 13, 2018

@sturman

This comment has been minimized.

Copy link
Author

commented Jun 14, 2018

Log

nvm@9ef00ffa3b8f:~/.nvm$ nvm install 0.6.20
Detected that you have 8 CPU core(s)
Running with 7 threads to speed up the build
Downloading https://nodejs.org/dist/v0.6.20/node-v0.6.20.tar.gz...
######################################################################## 100.0%
Computing checksum with sha256sum
Checksums matched!
$>./configure --prefix=/home/nvm/.nvm/v0.6.20 <
Checking for program g++ or c++          : /usr/bin/g++ 
Checking for program cpp                 : /usr/bin/cpp 
Checking for program ar                  : /usr/bin/ar 
Checking for program ranlib              : /usr/bin/ranlib 
Checking for g++                         : ok  
Checking for program gcc or cc           : /usr/bin/gcc 
Checking for gcc                         : ok  
Checking for library dl                  : not found 
Checking for openssl                     : not found 
Checking for function SSL_library_init   : not found 
Checking for header openssl/crypto.h     : not found 
/home/nvm/.nvm/.cache/src/node-v0.6.20/files/wscript:386: error: Could not autodetect OpenSSL support. Make sure OpenSSL development packages are installed. Use configure --without-ssl to disable this message.
nvm: install v0.6.20 failed!
nvm@9ef00ffa3b8f:~/.nvm$ 
Dockerfile Outdated
@@ -56,7 +56,8 @@ RUN apt update && \
g++-4.8 \
xz-utils \
build-essential \
bash-completion && \
bash-completion \
libssl-dev && \

This comment has been minimized.

Copy link
@PeterDaveHello

PeterDaveHello Jun 14, 2018

Contributor

I prefer to move this package upper so that we can focus and minimize the change/diff.

@ljharb

ljharb approved these changes Jun 14, 2018

Copy link
Collaborator

left a comment

LGTM assuming it’s ok with @PeterDaveHello

@PeterDaveHello
Copy link
Contributor

left a comment

LGTM now 👍

@PeterDaveHello

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2018

The commits should be squashed into a single one.

@sturman sturman force-pushed the sturman:add_libssl_to_docker_image branch from abbc8a0 to 29d43e4 Jun 18, 2018

@sturman

This comment has been minimized.

Copy link
Author

commented Jun 19, 2018

@PeterDaveHello commits are squashed into single one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.