Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] set install dir to $XDG_CONFIG_HOME/nvm, not $XDG_CONFIG_HOME #2013

Draft
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@bees
Copy link

commented Mar 8, 2019

seems to be the intent - wasn't happening when running the install script on bash 4.4.19 on Solus 3.9999

test output on my machine for master vs this branch:

nvm/test/install_script on master 
» ./nvm_install_dir 
nvm_install_dir should default to $XDG_CONFIG_DIR/.nvm. Current output: /home/ad/.config

nvm/test/install_script on master 
» git checkout -
Switched to branch 'update_install_dir_output'

nvm/test/install_script on update_install_dir_output 
» ./nvm_install_dir

nvm/test/install_script on update_install_dir_output 
» 

Marked draft as I still need to run through manually testing the shells listed in the CONTRIBUTING.md

[Fix] set install dir to XDG_CONFIG_HOME/nvm, not XDG_CONFIG_HOME
seems to be the intent - wasn't happening on bash 4.4.19 at least
@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Mar 10, 2019

The fix looks good, but please do update the PR status when you've tested fully :-)

@ljharb

This comment has been minimized.

Copy link
Collaborator

commented Apr 24, 2019

@bees ping?

@3ach

This comment has been minimized.

Copy link

commented May 2, 2019

I tested this on my current system and it worked, thanks to @bees for fixing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.