Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bash auto-use nvm command #2086

Merged
merged 1 commit into from Aug 17, 2019

Conversation

@smithgp
Copy link
Contributor

commented Aug 9, 2019

It was trying to read ./.nvmrc if you cd'ed into a subdirectory of the directory that has .nvmrc, which would give print -bash: ./.nvmrc: No such file or directory to stderr and potentially not doing the nvm install.

Fix bash auto-use nvm command
It was trying to read ./.nvmrc if you cd'ed into a subdirectory of the directory that has .nvmrc, which would give print `-bash: ./.nvmrc: No such file or directory` to stderr and potentially not doing the `nvm install`.
@ljharb

ljharb approved these changes Aug 10, 2019

Copy link
Member

left a comment

seems legit

@smithgp

This comment was marked as resolved.

Copy link
Contributor Author

commented Aug 12, 2019

HI, it looks like a test failed on installing zsh (https://travis-ci.org/nvm-sh/nvm/jobs/570004094):
E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/z/zsh/zsh-common_5.1.1-1ubuntu2.3_all.deb Could not connect to apt.cache.travis-ci.com:80 (34.96.81.152), connection timed out E: Failed to fetch http://archive.ubuntu.com/ubuntu/pool/main/z/zsh/zsh_5.1.1-1ubuntu2.3_amd64.deb Unable to connect to apt.cache.travis-ci.com:http:
which feels unrelated.
Can someone re-trigger the tests? Or, I can push an empty commit if that's what you usually do.
Thanks.

@ljharb

This comment was marked as resolved.

Copy link
Member

commented Aug 17, 2019

Sorry for the delay; I've reran it.

@ljharb ljharb merged commit 6537c91 into nvm-sh:master Aug 17, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.