Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed prefix check to work in case NVM_DIR is a link #2146

Open
wants to merge 6 commits into
base: master
from

Conversation

@GolanTrevize10
Copy link

GolanTrevize10 commented Jan 10, 2020

When NVM_DIR is a link, nvm mistakenly returns the error

nvm is not compatible with the npm config "prefix" option: currently set to "/data/jenkins-misc/nvm/versions/node/v8.10.0"
Run npm config delete prefix or nvm use --delete-prefix v8.10.0 to unset it.

With this fix nvm will check correctly that the prefix is inside the NVM_DIR

Copy link
Member

ljharb left a comment

realpath is not in POSIX, so this is a nonstarter.

@ljharb

This comment has been minimized.

Copy link
Member

ljharb commented Jan 11, 2020

Duplicate of #2045.

@ljharb ljharb closed this Jan 11, 2020
@ljharb ljharb reopened this Jan 11, 2020
…e quote
nvm.sh Outdated Show resolved Hide resolved
GolanTrevize10 and others added 2 commits Jan 13, 2020
Co-Authored-By: Jordan Harband <ljharb@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.