Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[readme] add nvm intro #2150

Merged
merged 1 commit into from Feb 9, 2020
Merged

[readme] add nvm intro #2150

merged 1 commit into from Feb 9, 2020

Conversation

@flip111
Copy link
Contributor

flip111 commented Jan 23, 2020

For #2149

Closes #2149.
@ljharb ljharb added the informational label Feb 9, 2020
@ljharb
ljharb approved these changes Feb 9, 2020
Copy link
Member

ljharb left a comment

i'll clean up these nits prior to landing

README.md Outdated
@@ -44,6 +45,10 @@

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

<a id="About"></a>>
## About
nvm is a version manager for nodejs and npm. Each user will gets his/hers own versions of nodejs. Nvm works on linux and macOS, windows might work but is not guaranteed.

This comment has been minimized.

Copy link
@ljharb

ljharb Feb 9, 2020

Member
  • "nodejs" is only what ubuntu calls it; it's node.js or node
  • "theirs" instead of "his/hers"; gender isn't binary
  • nvm should always be lowercased
  • nvm is guaranteed to work on Windows WSL, since it's POSIX-compliant.
  • nvm is not a version manager for npm.
README.md Outdated
@@ -44,6 +45,10 @@

<!-- END doctoc generated TOC please keep comment here to allow auto update -->

<a id="About"></a>>

This comment has been minimized.

Copy link
@ljharb

ljharb Feb 9, 2020

Member

i don't think this is necessary; headings are auto-linked. (also, extra >)

Suggested change
<a id="About"></a>>
@ljharb ljharb force-pushed the flip111:patch-1 branch from b9ee2d1 to 8093dbe Feb 9, 2020
@ljharb ljharb changed the title Update README.md [readme] add nvm intro Feb 9, 2020
@ljharb ljharb merged commit 8093dbe into nvm-sh:master Feb 9, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.