Skip to content
This repository has been archived by the owner on Apr 17, 2020. It is now read-only.

Video write APIs & proxy support #10

Merged
merged 12 commits into from Aug 3, 2016
Merged

Video write APIs & proxy support #10

merged 12 commits into from Aug 3, 2016

Conversation

stevenkissack
Copy link
Contributor

@stevenkissack stevenkissack commented Jul 27, 2016

Inspired by @marcusthebrown

Took me longer than I'd have liked but there is a bug in the MediaApi that the file data cannot be in the form ahead of the video data. That's why the following pull request doesn't look the neatest when attaching form data.

Anyway, list of changes is as follows:

  • create_video, update_video working
  • http requests now using request library for easier form stream handling
  • vows tests for create_video
  • proxy support
  • test video added
  • Video facade object to match searching design
  • fix package.json maintainer data type
  • progress event callback when known payload size (can't be a stream)

We are implementing this library within our product next week so I will submit more changes/fixes if I find them.

Thanks for your original work, got us a good head start!

@nwbb
Copy link
Owner

nwbb commented Aug 3, 2016

Sorry it took a bit to review it all - nice work!

@nwbb nwbb merged commit f4588da into nwbb:master Aug 3, 2016
@stevenkissack
Copy link
Contributor Author

Great news, thanks! If I get time I will implement the "add_image" api call in a different pull request.

@stevenkissack
Copy link
Contributor Author

@nwbb Can you publish the latest version to npm? I'm still getting the old one on "npm install"

@nwbb
Copy link
Owner

nwbb commented Aug 30, 2016

Yep, done.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants