Resolved Issue #3 (Cannot build with libgmime 3 or Debian 11/Bullseye) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…an 11/Bullseye) - Removed the override which forces gmime version detection to v2 - Fixed the transfer of the message date between Winlink and MIME header for gmime 3 - That seemed to be the last thing missing for gmime 3 to work, but I have not tested the serial transport - Doubled the fork process timeout to avoid spurious timeouts - Added a missing close() call in the forked process which appeared to be leaking sockets into the operating system The last item is especially weird, since I don't think it's supposed to be possible; the OS is supposed to close all file handles (including sockets) upon process exit, so maybe it represents a kernel or driver bug. Anyway, I find it a valuable workaround, as I would otherwise have to restart the radio stack after every run. This leak may happen anyway if the program closes abnormally, but at least it's fixed for the more common cases. If it persists, we might want to put the socket close in a signal or termination handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically, at the previous commit, you could build it, but it would segfault due to a type safety failure
and incompatibility.
The last item is especially weird, since I don't think it's supposed to be possible; the OS is supposed to close
all file handles (including sockets) upon process exit, so maybe it represents a kernel or driver bug. Anyway, I
find it a valuable workaround, as I would otherwise have to restart the radio stack after every run.
This leak may happen anyway if the program closes abnormally, but at least it's fixed for the more common cases.
If it persists, we might want to put the socket close in a signal or termination handler.