bash-it take II #2

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
2 participants

erichs commented May 23, 2012

here's an initial pass at reimplementing bash-it(). This porcelain function is a dispatch mechanism for the plumbing functions you created. The plumbing function names have been normalized to fit the dispatch convention.

notably absent to date is the _help-completions() function.

let me know what you think of this approach.

erichs added some commits May 22, 2012

plumb the depths
convert all metadata-related non-porcelain functions to plumbing.

by convention, plumbing functions start with an underscore, and contain
metadata prefixed by an underscore.

re-implement bash-it() as a dispatch mechanism for plumbing functions.
Collaborator

nwinkler commented May 23, 2012

Merged in your changes, thanks! Looks great and works without issues so far.

For the future, could you please update my remote branch before you commit your changes? Your changes were based on an older version, and the merge was quite painful :-(

@nwinkler nwinkler closed this May 23, 2012

erichs commented May 23, 2012

Sigh. Sorry @nwinkler. I am still learning git. Thanks for doing the merge.

On May 23, 2012, at 3:37 AM, nwinkler reply@reply.github.com wrote:

Merged in your changes, thanks! Looks great and works without issues so far.

For the future, could you please update my remote branch before you commit your changes? Your changes were based on an older version, and the merge was quite painful :-(


Reply to this email directly or view it on GitHub:
nwinkler#2 (comment)

Collaborator

nwinkler commented May 23, 2012

Sure, no problem - I'm new to git too and break things frequently. Or do things in a less than ideal way :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment