From b21891282c8eb88ab8201d4ce51907e700a736da Mon Sep 17 00:00:00 2001 From: Marton Hunyady Date: Tue, 29 May 2018 22:21:45 +0000 Subject: [PATCH] Add UMA histograms for enterprise rollback Adding the following UMA histograms: - UpdateEngine.Check.TargetVersion: first section of the Chrome OS target version set by device policy. - UpdateEngine.Check.RollbackTargetVersion: first section of the Chrome OS target version if rollback is also allowed. - UpdateEngine.EnterpriseRollback.Success: first section of the Chrome OS version to which rollback succeeded. - UpdateEngine.EnterpriseRollback.Failure: first section of the Chrome OS version to which rollback failed. Update_engine CL: crrev.com/c/1062033 BUG=843622 Change-Id: Ieb30b0bdc965be91c48e85fcf991a1a9116eb5e2 Reviewed-on: https://chromium-review.googlesource.com/1069129 Reviewed-by: Jesse Doherty Commit-Queue: Marton Hunyady Cr-Commit-Position: refs/heads/master@{#562631} --- tools/metrics/histograms/enums.xml | 5 ++ tools/metrics/histograms/histograms.xml | 70 +++++++++++++++++++++++++ 2 files changed, 75 insertions(+) diff --git a/tools/metrics/histograms/enums.xml b/tools/metrics/histograms/enums.xml index ffaeba1fc6710..5bd7b0bd3e374 100644 --- a/tools/metrics/histograms/enums.xml +++ b/tools/metrics/histograms/enums.xml @@ -45892,6 +45892,11 @@ Full version information for the fingerprint enum values: + + + + + diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 0c89da81cf12f..041fb77d33115 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -101456,6 +101456,42 @@ uploading your change for review. + + hunyadym@chromium.org + + First section of the Chrome OS target version set by device policy and sent + to Omaha if rollback is also allowed. This is a sparse histogram, since the + possible valid values are stable Chrome OS version prefixes (usually one per + milestone). + + Example value: 10323 (meaning M65 stable). + + This is reported on every update check if the TargetVersionPrefix device + policy is set and the value of the RollbackToTargetVersion device policy is + one of the values allowing rollback. + + This metric is specific to Chrome OS. + + + + + hunyadym@chromium.org + + First section of the Chrome OS target version set by device policy and sent + to Omaha. This is a sparse histogram, since the possible valid values are + stable Chrome OS version prefixes (usually one per milestone). + + Example value: 10323 (meaning M65 stable). + + This is reported on every update check if the TargetVersionPrefix device + policy is set. + + This metric is specific to Chrome OS. + + + zeuthen@chromium.org @@ -101492,6 +101528,40 @@ uploading your change for review. + + hunyadym@chromium.org + + First section of the Chrome OS version to which an enterprise rollback + (rollback initiated by the admin of the device) has failed. This is a sparse + histogram, since the possible valid values are stable Chrome OS version + prefixes (usually one per milestone). + + Example value: 10323 (meaning M65 stable). + + This is reported after a rollback image has failed installing. + + This metric is specific to Chrome OS. + + + + + hunyadym@chromium.org + + First section of the Chrome OS version to which an enterprise rollback + (rollback initiated by the admin of the device) has succeeded. This is a + sparse histogram, since the possible valid values are stable Chrome OS + version prefixes (usually one per milestone). + + Example value: 10323 (meaning M65 stable). + + This is reported after a rollback image has been successfully installed. + + This metric is specific to Chrome OS. + + + zeuthen@chromium.org