Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable symbolication of "adding an unknown subview" for frameless window #53

Closed
wants to merge 2 commits into from
Closed

disable symbolication of "adding an unknown subview" for frameless window #53

wants to merge 2 commits into from

Conversation

ghostoy
Copy link
Member

@ghostoy ghostoy commented Nov 16, 2016

As described in the issue, it's just a warning printed on console, and will actually crash the app. Fix it by suppressing the warning.

fixed nwjs/nw.js#5435

@rogerwang
Copy link
Member

merged. Thanks.

@rogerwang rogerwang closed this Nov 23, 2016
rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@tdanderson
Update 2x version of virtual keyboard icon
4c541c3 
Update the 2x version of the virtual keyboard icon
used in the IME detailed view of the Ash material
design system menu.

BUG=665976
TEST=manual

Review-Url: https://codereview.chromium.org/2512893002
Cr-Commit-Position: refs/heads/master@{#433286}
(cherry picked from commit 036067d)

Review URL: https://codereview.chromium.org/2517243003 .

Cr-Commit-Position: refs/branch-heads/2924@{#53}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
Make WebView no operation when render process died
97cc7ce 
BUG=666106

Review-Url: https://codereview.chromium.org/2643333003
Cr-Commit-Position: refs/heads/master@{#445410}
(cherry picked from commit f85d298)

Review-Url: https://codereview.chromium.org/2651563006 .
Cr-Commit-Position: refs/branch-heads/2987@{#53}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
cros - Show progress bar in network detailed view when scanning for w…
5a1bc9b 
…ifi networks

BUG=649799

Review-Url: https://codereview.chromium.org/2722373002
Cr-Commit-Position: refs/heads/master@{#454905}
(cherry picked from commit 462cc9a)

Review-Url: https://codereview.chromium.org/2740533003 .
Cr-Commit-Position: refs/branch-heads/3029@{#53}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
@JohnChen0
Fix crash when automation infobar is closed
338ccfc 
When Chrome is started with --enable-automation switch (e.g., when it
is started by ChromeDriver), it display an infobar indicating the fact.
If the user attempts to close this infobar, it used to crash Chrome.
Closing other global infobars when --enable-automation switch is used
can also crash Chrome.

BUG=706735
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2807403002
Cr-Original-Commit-Position: refs/heads/master@{#464676}
Review-Url: https://codereview.chromium.org/2816373002
Cr-Commit-Position: refs/branch-heads/3071@{#53}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
@tim-loh
Log site engagement scores for permission actions
7ba12ce 
This patch adds histograms for tracking site engagement scores for
permission prompts, Permissions.Engagement.[Action].[Permission].

BUG=731349
TBR=timloh@chromium.org

(cherry picked from commit 102eac8)

Review-Url: https://codereview.chromium.org/2952003003
Cr-Original-Commit-Position: refs/heads/master@{#488573}
Change-Id: I4b10ae633ba54e6f3c2af22058af95a2a55391ab
Reviewed-on: https://chromium-review.googlesource.com/584561
Reviewed-by: Timothy Loh <timloh@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#53}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
@galmacky
Fix a crash in TextView#onSaveInstanceState
95cf740 
On Android JB, TextView#onSaveInstanceState() calls new
SpannableString() which causes a crash.

The reason is that SpannableStringInternal#setSpan() eventually calls
ChangeWatcher#onSpanChanged() and this causes onSelectionChanged().
However, the selection values remain the same, so we can simply ignore
the call when the values did not change.

BUG=760013

(cherry picked from commit acfc998)

Change-Id: I907afd43dae36513b8015572a5568060d8b545b3
Reviewed-on: https://chromium-review.googlesource.com/644495
Commit-Queue: Changwan Ryu <changwan@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499100}
Reviewed-on: https://chromium-review.googlesource.com/653211
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#53}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
@wangxianzhu
Invalidate layer when its composited scrolling status changed
2dcf849 
When a composited scrolling layer's object is set 'pointer-events:none',
the layer will no longer use composited scrolling (though it is still
composited). This is controlled by ComputedStyle::VisibleToHitTesting().
When this happens, no other conditions trigger invalidation of the
layer. Now invalidate a layer when its composited scrolling status
changed.

TBR=wangxianzhu@chromium.org

(cherry picked from commit 9ba2227)

Bug: 758474
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I3c01a543a5424d8c746e901047abc606874e0290
Reviewed-on: https://chromium-review.googlesource.com/717028
Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509172}
Reviewed-on: https://chromium-review.googlesource.com/726379
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3239@{#53}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
media/gpu/v4l2_vda: Use correct format for checking in import buffer.
20902ad 
The "output_format_fourcc_" may not be the final output format if an
image processor is needed to convert the format. (It is always
needed, the import mode is only supported with image processor)

Use "egl_image_format_fourcc_" instead, it will be the final output
format in both import/allocate mode.

Bug: b/72286007
Test: Play videos in ARC++.
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0473c84c6b4a13f96934dd0bf2208ba9f3aa916f
Reviewed-on: https://chromium-review.googlesource.com/879903
Commit-Queue: Owen Lin <owenlin@chromium.org>
Reviewed-by: Kuang-che Wu <kcwu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#531173}(cherry picked from commit 91175b1)
Reviewed-on: https://chromium-review.googlesource.com/882701
Reviewed-by: Owen Lin <owenlin@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#53}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
VR: Prompt user to update their keyboard version if needed
af670aa 
This CL renames AudioPermissionPrompt and its corresponding texture to
Prompt and uses the same texture for the exit prompt.

Bug: 799584
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If435488f3e10a2f704d7e4df2177756e4d7aaa15
Reviewed-on: https://chromium-review.googlesource.com/945110
Commit-Queue: Yash Malik <ymalik@chromium.org>
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540573}(cherry picked from commit dd8e1f5)
Reviewed-on: https://chromium-review.googlesource.com/952745
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#53}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@xiaochengh
Return null InlineBoxPosition if no last text box.
6615906 
This patch fixes the crash bug on Android.

Bug: 831057
Change-Id: I94c6a893aad63894609eb34a78bba095596555d6
Reviewed-on: https://chromium-review.googlesource.com/1005636
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550563}(cherry picked from commit ab8610e)
Reviewed-on: https://chromium-review.googlesource.com/1013878
Cr-Commit-Position: refs/branch-heads/3396@{#53}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Apr 27, 2018
@xiaochengh
Return null InlineBoxPosition if no last text box.
735cf80 
This patch fixes the crash bug on Android.

TBR=yoichio@chromium.org

(cherry picked from commit 6615906)

Bug: 831057
Change-Id: I94c6a893aad63894609eb34a78bba095596555d6
Reviewed-on: https://chromium-review.googlesource.com/1005636
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Original-Original-Commit-Position: refs/heads/master@{#550563}(cherry picked from commit ab8610e)
Reviewed-on: https://chromium-review.googlesource.com/1013878
Cr-Original-Commit-Position: refs/branch-heads/3396@{#53}
Cr-Original-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
Reviewed-on: https://chromium-review.googlesource.com/1018202
Cr-Commit-Position: refs/branch-heads/3359@{#737}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
@tanderson-google
Revert "enable libaom"
839e351 
This reverts commit 80428a9.

AV1 is not ready for the beta channel. Disable it on the M68 branch.

BUG=847642

Change-Id: Ie65181d29550caefbf28540964218c7ae4e6982b
Reviewed-on: https://chromium-review.googlesource.com/1079796
Reviewed-by: Johann Koenig <johannkoenig@google.com>
Cr-Commit-Position: refs/branch-heads/3440@{#53}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
[unified-consent] Enable spell-check when user opts into unified consent
fb52bed 
- When the user opts into unified consent, spell-check is enabled.
- When the user signs out of Chrome, spell-check is disabled.

Bug: 865370
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I436a90e1008fcef08168115256237179d6c6d14c
Reviewed-on: https://chromium-review.googlesource.com/1143275
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#576838}(cherry picked from commit 5ec4b21)
Reviewed-on: https://chromium-review.googlesource.com/1148362
Reviewed-by: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#53}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@sebsg
Merge-70 [AF] Clean up Autofill settings toggles.
19e310e 
Remove the master toggle.
Add sublabels for the profile and credit card toggles.
Add row to inform users if an extention is managing the toggles.
Change the title from "Addresses" to "Addresses and more".

TBR=sebsg@chromium.org

(cherry picked from commit 2e8a676)

Bug: 860526, 877801
Change-Id: I2d0d156108667d9463263f4e490761a506bf9a13
Reviewed-on: https://chromium-review.googlesource.com/1196924
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588148}
Reviewed-on: https://chromium-review.googlesource.com/1207215
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#53}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
@mspang
ozone: evdev: Add quirk to force USB 0x18d1:0x5030 as internal
2220d68 
This adds a quirk to force this device as internal so that it behaves
correctly in tablet mode.

Bug: b/116723180
Test: please

Change-Id: Ica3ace1098daf090e843ffb03bb27ef07d5144a1
Reviewed-on: https://chromium-review.googlesource.com/c/1280845
Reviewed-by: Kevin Schoedel <kpschoedel@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599732}(cherry picked from commit 1d6ccd8)
Reviewed-on: https://chromium-review.googlesource.com/c/1283944
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#53}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
Updating XTBs based on .GRDs from branch 3626
532a6ea 
R=kariah@chromium.org

Change-Id: I5811ca6db7c4109dc6ccae06cce552a18e299384
Reviewed-on: https://chromium-review.googlesource.com/c/1361726
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#53}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@natechapin
Allow <iframe src="javascript:''"> to commit synchronously.
f506ced 
https://crrev.com/624035 made all javascript url navigations async.
Some sites appear to depend on "javascript:''" behaving like
"about:blank" and committing synchronously.

The spec doesn't say anything about this, but given the real-world
breakage, I'm inclined to consider this a very narrow partial revert
of https://crrev.com/624035 while we figure out whether this is a spec
oversight or a case where we just need to encourage libraries to update.

Bug: 923585
Change-Id: Ia030d0a06b5d8f20df319916a1a02297d916e4db
Reviewed-on: https://chromium-review.googlesource.com/c/1435821
Commit-Queue: Nate Chapin <japhet@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626261}(cherry picked from commit d928b7d)
Reviewed-on: https://chromium-review.googlesource.com/c/1444299
Reviewed-by: Nate Chapin <japhet@chromium.org>
Cr-Commit-Position: refs/branch-heads/3683@{#53}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
@michaeldo1
Do not access web state while the CRWWebController is being destroyed.
b760288 
Bug: 935555
Change-Id: I3ace36ecc6ec84205b90edb57de6c2c993201bec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1489713
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#639194}(cherry picked from commit 43bb9fdd8e623691e6529987777ebe8a5a2ab365)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518894
Reviewed-by: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#53}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostoy @rogerwang