Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Create an independent npm module out of it #46

Closed
steffenmllr opened this Issue · 20 comments

8 participants

@steffenmllr

As I want to support gulp and grunt, it would make sense to port the builder into a separate npm module and only make a wrapper for grunt and gulp -> https://github.com/mllrsohn/node-webkit-builder

@adam-lynch
Collaborator

:+1:

@adam-lynch adam-lynch referenced this issue in Anonyfox/node-webkit-hipster-seed
Closed

Use gulp in place of grunt #6

@feross

:+1:

What's the progress on this? Does node-webkit-builder have parity yet?

@feross

I may be able to help out with this. What needs to be done?

@steffenmllr

@feross have a look at the repo / tests. one prob is that the "get-latest-version" stuff doesn't work anymore (because nw isn't hosted on aws anymore), the cli stuff is missing and that's about it - the rest should work.

@ivantodorovich

@feross Are you sure about nw not being hosted in aws?

I don't know the status of nw 14 days ago, but it is hosted now.

This is taken from nodewebkit's install.js script, and tested on windows:

// Determine download url
if (process.platform === 'darwin') {
  url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-osx-ia32.zip';
} else if (process.platform === 'win32') {
  url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-win-ia32.zip';
} else if (process.arch === 'ia32') {
  url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-linux-ia32.tar.gz';
} else if (process.arch === 'x64') {
  url = 'http://s3.amazonaws.com/node-webkit/v' + version + '/node-webkit-v' + version + '-linux-x64.tar.gz';
}
@steffenmllr

nw was hostet on aws - it's not anymore - so the auto-get-newest-version needs some work. Maybe ask rogerwang in #68 if he could provide a json with the dir list or maybe parse the github release api...

@ivantodorovich

The install script I posted successfully downloads nw binaries. Tested on win7
http://s3.amazonaws.com/node-webkit/v0.9.2/node-webkit-v0.9.2-linux-x64.tar.gz
Downloads just fine

@steffenmllr

hmm we should ask rogerwang if it's ok to use the aws link

@ivantodorovich
@steffenmllr

There is also still some stuff left to at: https://github.com/mllrsohn/node-webkit-builder

  • the cli stuff
  • testing

I'm pretty full the next weeks with client work so any help is appreciated :)

@ivantodorovich

Ok, I'll try to help :)

@steffenmllr

There you go: https://github.com/mllrsohn/node-webkit-builder
There might be some bug, so some feedback would be nice :)

@steffenmllr

@adam-lynch you can get rid of grunt now - would be great if you could test the first version

@adam-lynch
Collaborator

giphy

@steffenmllr Great! I'll test this when I get a chance. What kind of bugs should I look out for?

@steffenmllr

make sure it works on linux and windows
make sure you install with npm install mllrsohn/node-webkit-builderto get the latest version from github, I'll try to get a code coverage tool to see where the bilnd spots are.

@dylangattey

What''s the status of this?

@konsumer

I'd love to help with a brunch version, too, using the same lib.

@steffenmllr

@konsumer pls check: https://github.com/mllrsohn/node-webkit-builder there is one bug in the linux build everything else should work I don't really have a lot of time atm so help is appreciated

@gabepaez gabepaez closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.