"new-win-policy" event does not fire for popup windows

[semmel]

The event does not fire for windows opened by gui.Window.open()
It just works for the main window and its child iframes.
Tested with Windows 7 32bit node-webkit v. 0.9.0rc1.
For a demo paste the code into the dev console of node-webkit:

var gui = require('nw.gui');
// for the main window it works fine:
var nwWindow = gui.Window.get();
nwWindow.window.document.body.innerHTML = '<a href="https://www.google.de" target="_blank">Go to Google</a>';
nwWindow.on('new-win-policy', console.log.bind(console, "main window"));
// clicking the link now logs to the console - Fine!

// for popups the event is not fired:
var nwPopup = gui.Window.open("http://www.example.com", {
    toolbar: false, nodejs:false, "new-instance": false});
nwPopup.window.document.body.innerHTML = '<a href="https://www.google.de" target="_blank">Go to Google</a>';
nwPopup.on('new-win-policy', console.log.bind(console, "popup window"));
// clicking the link does not fire the event :-(

[rogerwang]

Thanks for reporting. I'll fix this.

The event is intent to capture new window from 3rd party content. So gui.Window.open() case was left behind.

btw, you could try 'window.open()' before it's fixed.

[rogerwang]

The fix requires deeper modifications where the ID of window is handled. I tend to push it to 0.9.1 to keep 0.9.0 more stable than rc1.

[semmel]

That's fine. I just wanted to report.
My link replacement code

/// Overwrite links with target=_blank to open in real browser
Array.prototype.forEach.call(outputFrame.contentDocument.querySelectorAll('a[target=_blank]'),
    function(link)
    {
        link.addEventListener('click', function(evt)
            {
                gui.Shell.openExternal(link.href);
                evt.preventDefault();
            },
            false
        );
    }
);

is still in place as a workaround.
Cheers,
Matthias