spell-check available? #332

Closed
pcarion opened this Issue Jan 10, 2013 · 33 comments

Comments

Projects
None yet

pcarion commented Jan 10, 2013

Hi,

Is it possible to enable the google spell-check which is available under chrome (using right click)?

Thank you

Pierre

jkramp commented Mar 20, 2013

I too am looking for spell check and cannot get it working so I am guessing it is not implemented

rhiokim commented Oct 6, 2013

+1

timhall commented Nov 5, 2013

👍

HaiColon commented Nov 9, 2013

+1

Would be great if we could get some information about if this is even possible or if it isn't for some reason. If not, I would start writing my own.

@rhiokim rhiokim referenced this issue in rhiokim/haroopad Jan 14, 2014

Open

spell checking #147

uglide commented Jan 30, 2014

+1

+1

Contributor

Mithgol commented Mar 14, 2014

Would be great if we could get some information about if this is even possible or if it isn't for some reason. If not, I would start writing my own.

I suppose it's not possible because spellcheck, while being a part of Google Chrome, has never made it to those parts of Chromium that node-webkit is based on.

However, I do not have a perfect understanding of node-webkit's internals. We should call @rogerwang to chime in here and confirm (or refute) my assumption.

Even if this doesn't become part of the core, the spellchecker modules that I have seen out in the open source world are mostly unmaintained and outdated. Therefore, there's an opportunity here for anyone wanting to write a module that just plain solves the problem without needing to hack away at node-webkit. Hope this helps.

@rogerwang rogerwang self-assigned this Aug 26, 2014

rhalff commented Nov 11, 2014

+1

Would be nice to have for example for use in:
https://github.com/GitbookIO/editor/issues/51

+1, I was thinking about how this could work. I kind of wonder if there should be a function or setting to switch the system menu on if contenteditable is true...

or maybe you create a context menu and use a function to inject the system menu ...

@ToddKoz ToddKoz referenced this issue in drikin/slk Dec 8, 2014

Open

No spell checking #6

drikin commented Dec 9, 2014

+1

FYI, atom-shell have added spell-check support; atom/atom-shell#942

I suppose it's not possible because spellcheck, while being a part of Google Chrome, has never made it to those parts of Chromium that node-webkit is based on.

My understanding is it is implemented in Chromium:
http://www.chromium.org/developers/how-tos/editing-the-spell-checking-dictionaries
http://hunspell.sourceforge.net/

+1
Is there any status on this @rogerwang ?
Anyone has any good modules/workarounds?

+1
anyone got a solution for this? or we still waiting for feedback from @rogerwang ?

Member

rogerwang commented Mar 14, 2015

Will try to fix this in nw13.

On 2015年3月15日周日 上午5:41 Muzikayise Flynn Buthelezi notifications@github.com
wrote:

+1
anyone got a solution for this? or we still waiting for feedback from
@rogerwang https://github.com/rogerwang ?


Reply to this email directly or view it on GitHub
#332 (comment).

Contributor

TheJaredWilcurt commented Mar 31, 2015

If you need something in your app prior to NW.js v.13, there are several JavaScript based spellcheck libraries available that should tide you over.

Adds about 1MB to your project size:


Edit: That link requires PHP, use Typo.js instead.

@adidalal adidalal referenced this issue in aluxian/Messenger-for-Desktop Apr 14, 2015

Closed

[REQ] In-app spellchecker #32

Member

rogerwang commented Jun 11, 2015

Released in 0.13.0-alpha1 with --enable-spell-checking switch: https://groups.google.com/d/msg/nwjs-general/c25l_jGMqj8/rsAtdSQuxeUJ

@rogerwang rogerwang closed this Jun 11, 2015

@rogerwang will it always be behind this --enable-spell-checking switch or is that just for alpha builds?

Member

rogerwang commented Jun 11, 2015

@adam-lynch yes. It will always be like that unless other ways are proposed.

The current implementation uses the same one inside Chromium browser. The feature is builtin so app developers don't have to write their own spell check providers. In the upcoming alpha releases there will be options to control the language support for the spell checker.

In future releases we'll provide an API for writing your own spell checker provider. If anyone need this before that please open a new issue.

@rogerwang thanks for that. I'm not sure how I'd pass that flag when I give an end user my .exe / .app. Maybe it could also be a property in the JSON manifest?

I'm assuming that if I were to put it in chromium-args with the current alpha build it wouldn't work because chromium-args is for Chromium stuff only.

Member

rogerwang commented Jun 11, 2015

@adam-lynch it should work with chromium-args

@rogerwang Great thanks! 👍

S-ed commented Feb 10, 2016

How to define dictionary file?
Afaik there is a Chromium API function to do so.
Would be nice to have an ability to switch them on the go.

laduran commented Feb 15, 2016

Does anyone know whether or not in the 0.13 beta 5 if the spell check dictionary can be either extended or replaced? I want a medical dictionary. Yes, I know javascriptspellcheck has this, I looked at that already and it has a server dependency that I don't think we can use for our packaged app (unless someone can tell me how to add PHP support to the node server that webkit uses).

Contributor

TheJaredWilcurt commented Feb 16, 2016

@laduran

That one doesn't require any PHP nonsense. I had no idea that "JavaScript Spellchecker" was a Scooby Doo villain. Once I pull off its mask it turns it it was "PHP Spellchecker" all along. He would have gotten away with it to if it wasn't for your meddling, laduran!

laduran commented Feb 16, 2016

@TheJaredWilcurt

Ha! I was looking at Typo.js as you wrote that. Yeah, just a client side Javascript library. Seems super barebones though. Very low level. I have to write all the UI pieces myself. For example, squiggly underline misspelled words, context menu to show suggested corrections, etc. It may as well be assembly language. :-)

laduran commented Feb 16, 2016

By the way, my ideal solution would still be to update to NWJS v0.13 and use built in spell correction. In addition, it would be nice to be able to replace the built-in dictionary with a Hunspell compatible medical dictionary. For example: Hunspell Medical Dictionary

Two simple, I hope, questions. Is spell check implemented/available for v0.13.1? If yes, how do i enable it? Keep any discussion of enabling simple, I'm an end user not a programmer.

Thanks
John

laduran commented May 4, 2016

Honestly, we switched from NWJS to Electron mostly because of the poor spell check support in NWJS. We could never get it working per user expectations in NWJS and just getting it working poorly took more work than necessary. Have a look at Electron.

Member

rogerwang commented May 4, 2016

The dictionary can be customized in the same way as in Google Chrome, see https://www.quora.com/Is-there-a-way-to-remove-a-word-from-Chromes-spell-check-dictionary

Member

rogerwang commented May 4, 2016

btw, In 0.13 we changed to an optimized architecture so more features can be supported beyond spell checking, see http://nwjs.io/blog/whats-new-in-0.13/ and it's good for keeping up with Chromium upstream -- we released with Node.js v6.0 and new Chromium versions within 1 day after upstream release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment