Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom app icon with incorrect size under volume mixer #4649

Closed
Yonezpt opened this issue Mar 30, 2016 · 4 comments
Closed

Custom app icon with incorrect size under volume mixer #4649

Yonezpt opened this issue Mar 30, 2016 · 4 comments
Assignees
Milestone

Comments

@Yonezpt
Copy link

Yonezpt commented Mar 30, 2016

When setting a custom icon for the app in the manifest "window":{"icon": "icon.png"}, it will show with an incorrect size under the volume mixer.

The following example shows the result of a simple app playing a YouTube video and the custom icon used in the manifest is NWJS's own icon. The icon displayed in the volume mixer is too big as you can see:

ss

Not using a custom icon in the manifest displays the default icon with the correct size.

NWJS: v0.13.2 SDK
OS: Win7x64

@rogerwang rogerwang added this to the 0.13.x milestone Mar 30, 2016
@rogerwang
Copy link
Member

What's the DPI setting of your system?

@Yonezpt
Copy link
Author

Yonezpt commented Apr 1, 2016

Standard Windows 96 DPI, no retina display or anything similar.

ss

The same problem happens on my laptop with same DPI and OS.

@ghostoy
Copy link
Member

ghostoy commented Apr 7, 2016

This issue also appears on upstream Chromium. I've reported in here https://bugs.chromium.org/p/chromium/issues/detail?id=601276. The fix is done in PR nwjs/chromium.src#14

@rogerwang
Copy link
Member

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants