Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docs on Mac Signing; Current Docs Are Old #6325

Open
codekiln opened this issue Dec 12, 2017 · 8 comments
Open

Update Docs on Mac Signing; Current Docs Are Old #6325

codekiln opened this issue Dec 12, 2017 · 8 comments

Comments

@codekiln
Copy link

codekiln commented Dec 12, 2017

NWJS Version : latest is 0.27.1 as of right now
Operating System : Mac

Expected behavior

The docs should explain the current best practice on signing Mac apps made with nw.js.

Actual behavior

The docs on the Mac App Store are unclear and possibly invalid.

  • where should users find build_mas.py? The only place I could find them was in a custom branch in the repo.
  • there hasn't been a MAS build of nw.js for nearly a year. It's not clear whether these instructions are still valid. Perhaps we should put a "last updated as of version" comment at the top of the page.
  • Instructions should be oriented toward signing to get past gatekeeper, with an additional section on the Mac App Store, since most users distributing applications for mac will need to get past gatekeeper, but only a small subset of those users will distribute through the mac app store.
  • Instructions should include a section about how to sign if you need a native messaging application included.

Related Tickets

@rogerwang
Copy link
Member

The MAS build is still on 0.19, and yes it's in a different branch, should be 'nw19-mas'. @sunlin-link is working on an update for the latest NW stable version.

@codekiln
Copy link
Author

codekiln commented Dec 12, 2017

I've heard in the nwjs google group that one doesn't necessarily need the MAS build to successfully sign a nw.js app. Is there any reason why this wouldn't be true? I have an application working in a later version of nw.js, and I'd rather not port it back to 19 and re-QA it just to sign it.

@rogerwang
Copy link
Member

rogerwang commented Dec 12, 2017 via email

@rogerwang
Copy link
Member

rogerwang commented Dec 12, 2017 via email

@codekiln
Copy link
Author

Thank you, this helps a lot.

@ncnlinh
Copy link

ncnlinh commented Apr 12, 2018

Is there any update on nwjs of older version with MAS build?

@gpetrov
Copy link

gpetrov commented Aug 19, 2018

@sunlin-link and @rogerwang any progress on updating the MAS build? It is running way behind now and we can really use the latest ...

@codekiln
Copy link
Author

FYI - while the type of signing might not be suitable for the mac app store (untested), I have a PR up for nwjs-builder-phoenix that adds regular signing to mac and windows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants