Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nwjs app crashes on addOriginAccessWhitelistEntry #6858

Closed
FahadQurashi49 opened this issue Nov 7, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@FahadQurashi49
Copy link

commented Nov 7, 2018

NWJS Version : 0.34.1
Operating System : macOS High Sierra

Expected behavior

Should start the application like it does with NWJS v0.33.4

Actual behavior

The application get crashed when it reaches line code:
App.addOriginAccessWhitelistEntry('http://github.com/', 'chrome-extension', location.host, false);
giving error:


# Fatal error in , line 0
# Check failed: receiver->IsJSFunction().
#
#
#
#FailureMessage Object: 0x7ffee846af200   nwjs Framework                      0x000000010dfb3a6c v8_inspector::V8StackTraceId::IsInvalid() const + 7742460
1   nwjs Framework                      0x0000000110c9597b v8_inspector::V8StackTraceId::IsInvalid() const + 54805259
2   nwjs Framework                      0x0000000110c86d85 v8_inspector::V8StackTraceId::IsInvalid() const + 54744853
3   nwjs Framework                      0x000000010d50db78 v8::internal::Object::ToInt32(int*) + 7608
4   nwjs Framework                      0x0000000111f01203 v8_inspector::V8StackTraceId::IsInvalid() const + 74120083
5   nwjs Framework                      0x000000010da901d1 v8_inspector::V8StackTraceId::IsInvalid() const + 2354017
6   nwjs Framework                      0x000000010d081e64 v8::internal::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, v8::internal::BasicBlockProfiler const&) + 130964
7   nwjs Framework                      0x000000010d0813ad v8::internal::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, v8::internal::BasicBlockProfiler const&) + 128221
8   nwjs Framework                      0x000000010d080b1a v8::internal::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char> >&, v8::internal::BasicBlockProfiler const&) + 126026
9   nwjs Framework                      0x000000010d8ebc8e v8_inspector::V8StackTraceId::IsInvalid() const + 632350
Received signal 4 <unknown> 000110c88f92
 [0x00010dfb3a6c]
 [0x00010dfb3961]
 [0x7fff6edb2f5a]
 [0x7fa0df629e5c]
 [0x00010d50db78]
 [0x000111f01203]
 [0x00010da901d1]
 [0x00010d081e64]
 [0x00010d0813ad]
 [0x00010d080b1a]
 [0x00010d8ebc8e]
[end of stack trace]

How to reproduce

I have made a sample project reproducing this error on macOS High Sierra, also dump files are also attached in the project:
Sample project

@gpetrov

This comment has been minimized.

Copy link

commented Nov 7, 2018

See #6631 (comment)
you must use web_accessible_resources

@rogerwang rogerwang closed this in 64c8c20 Nov 13, 2018

@rogerwang

This comment has been minimized.

Copy link
Member

commented Nov 13, 2018

This is fixed in git and will be available in the next nightly build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.