Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboard ↑↓←→ make nw 0.36.2 crash when enable-features=nw2 #6976

Closed
chatcan opened this issue Feb 19, 2019 · 4 comments

Comments

Projects
None yet
3 participants
@chatcan
Copy link

commented Feb 19, 2019

Thanks for reporting an issue! Spend 60 seconds reading this...

  1. Before reporting, try reproducing against the latest version of NWJS.
  2. Issue tracker is only for bugs and feature requests, in English only.

Anything else? Use our mailing list for questions:
https://groups.google.com/forum/#!forum/nwjs-general

======== TEMPLATE BUG FORM ========

NWJS Version : 0.36.2
Operating System : Mac 10.14

Expected behavior

input correctly

Actual behavior

crash

How to reproduce

enable-features=nw2
inspect nwjs , focus on the devtools window and press → key

@chatcan chatcan changed the title keyboard ↑↓←→ make nw 0.36.2 crash when enable-feature=nw2 keyboard ↑↓←→ make nw 0.36.2 crash when enable-features=nw2 Feb 19, 2019

@chatcan

This comment has been minimized.

Copy link
Author

commented Feb 19, 2019

cmd+c, cmd+p, cmd+v cause crash

@ffanny

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

With nwjs-sdk-win&linux-v0.36.2, it doesn't crash.
And I am not sure if there is a problem with osx-v0.36.2, the mac version.

@chatcan

This comment has been minimized.

Copy link
Author

commented Feb 20, 2019

test 2.zip

const menu = new nw.Menu({type: 'menubar'})
const ideMenu = new nw.Menu()

ideMenu.append(new nw.MenuItem({
  label: 'a',
}))

menu.append(new nw.MenuItem({
  label: 'b',
  submenu: ideMenu,
}))
nw.Window.get().menu = menu

package.json

{
  "main":"index.html",
  "name":"cantest",
  "appname":"cantest",
  "window": {
    "width": 800,
    "height": 474,
    "frame": false
  }
}
@Blatman

This comment has been minimized.

Copy link

commented Feb 21, 2019

Just tried the test zip and got the problem to occur using 10.13.6 and 0.36.3-sdk and 0.37.0b1-sdk.
Had to add the nw2 switch to package.json of course but fails with Trap 14 error if frame is false -
works OK if frame is true.

Note this issue should be included with #5875 as it is related to nw2 switch.
Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.