Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(windows 7 64) 0.7.0 nw.exe still in memory after using a "close/quit" command #984

Closed
naelian opened this issue Aug 13, 2013 · 12 comments
Closed
Labels
Milestone

Comments

@naelian
Copy link

naelian commented Aug 13, 2013

Everything is ok using the quit "button" but not using the close command ... it's very important for fullscreen projects and was working fine in previous 0.6x release.

=> I test this new nw release into Construct2 (Scirra)

please delete and sorry for this bug reporting twice

@kingFighter
Copy link
Contributor

@naelian What do you mean by close/quit command? Do you mean Window.close and gui.App.quit ?
With win 64 bit 0.7.0, I cannot reproduce it.

@naelian
Copy link
Author

naelian commented Aug 15, 2013

@kingFighter, yes Construct 2 build the code and seems sending a window "nwgui App quit" ... then one nw.exe process is not kill when i force exiting AND a sound/music is playing ... you can find a example here (http://db.tt/Lrm35wUI), on this screensaver project click on the window to force exit and reproduce the bug

@kingFighter
Copy link
Contributor

@naelian I tried and I can reproduce it with gui.App.quit. But the window.close() works fine

@naelian
Copy link
Author

naelian commented Aug 15, 2013

Yes i say "close" because Construct2 command is "Browser.close" generating a gui.App.quit ... the most important is to have a unique and clean way to quit nw without having to click on close button in a frame window ... using gui.App.quit seems to be no more this clean way ...

@naelian
Copy link
Author

naelian commented Aug 19, 2013

Not fix In 0.7.1 ... same package ... same problem

@rogerwang
Copy link
Member

the referred commit 4a27354 did fix this but commit ad079b5 later makes the issue happen again.

@richardcypher
Copy link
Contributor

@naelian , is there any way to reproduce the bug with some simple codes instead of your project? Maybe you could provide the whole process to reproduce it? I cannot reproduce it just using gui.App.quit.

@naelian
Copy link
Author

naelian commented Aug 20, 2013

@richardcypher, sorry i can't provide you something more simple to reproduce this bug. My link package is not minified so you can edit it and search "close", that will give you the syntax use to exit nw. I can just say you that it's happening when a sound is played and gui.App.quit use to exit ... (mixer probably not close using gui.App.quit as rogerwang said) and so the nw.exe process isn't killed.

Following Kingfighter advice i test changing the App.quit to regular window.close() and it's working well ... but as i use a code builder (Construct 2 Scirra), i can't change this line everytime i rebuild my package. I'm pretty sure that Scirra use this gui.App.quit instead of window.close() because it was more reliable with older releases of nw (0.6.X) ... i just need to know the real clean method to use working on all platform so i can ask for a change in Scirra code builder.

@richardcypher
Copy link
Contributor

@naelian , I want to add a test case for this bug, is it ok to use the code you provided?

@rogerwang
Copy link
Member

fixed again with this commit b67a7d8

@naelian
Copy link
Author

naelian commented Aug 21, 2013

@richardcypher, no problem you can use code provided

@richardcypher
Copy link
Contributor

@naelian ok, thanks

richardcypher added a commit to richardcypher/node-webkit that referenced this issue Aug 21, 2013
richardcypher added a commit to richardcypher/node-webkit that referenced this issue Aug 21, 2013
rogerwang added a commit that referenced this issue Aug 22, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants