Skip to content

Commit 56c770a

Browse files
committed
fix(core): aliases were not being picked up when generating projects w/ solution files
1 parent 3d91672 commit 56c770a

File tree

5 files changed

+9
-77
lines changed

5 files changed

+9
-77
lines changed

docs/core/generators/app.md

Lines changed: 0 additions & 39 deletions
This file was deleted.

docs/core/generators/lib.md

Lines changed: 0 additions & 35 deletions
This file was deleted.

docs/core/guides/handling-solutions.md

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,19 @@ To add projects to a solution file by default, you can set the generator default
1515
// ... more nx.json configuration
1616
generators: {
1717
// ... other default configurations
18-
'@nx-dotnet/core:app': {
18+
'@nx-dotnet/core:application': {
1919
solutionFile: true,
2020
},
21+
// ... other default configurations
22+
'@nx-dotnet/core:library': {
23+
solution: 'my-sln.sln',
24+
},
2125
},
2226
}
2327
```
2428

29+
> Note that the generator names in `nx.json` must be the full name. Alias's like `app`, `lib` and so on will not be recognized.
30+
2531
## Subgraph Solutions
2632

2733
In a large monorepo, IDEs or other tooling may slow down when presented with a large solution file. Currently, `nx-dotnet` does not assist in managing this issue, but there are a few easy steps to take that can help optimize your workflow. Which path you take will depend on both the tooling you use, and the pains that you are enountering.

packages/core/src/generators/app/schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@
7676
"description": "Should the project be added to the default solution file?"
7777
}
7878
],
79-
"alias": ["solution", "s"]
79+
"aliases": ["solution", "s"]
8080
}
8181
},
8282
"required": ["name", "template", "language"]

packages/core/src/generators/lib/schema.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@
7070
"description": "Should the project be added to the default solution file?"
7171
}
7272
],
73-
"alias": ["solution", "s"]
73+
"aliases": ["solution", "s"]
7474
}
7575
},
7676
"required": ["name", "template", "language", "testTemplate"]

0 commit comments

Comments
 (0)