fix(core): include serve target only for applications#30
Merged
AgentEnder merged 2 commits intonx-dotnet:devfrom Apr 27, 2021
Merged
fix(core): include serve target only for applications#30AgentEnder merged 2 commits intonx-dotnet:devfrom
AgentEnder merged 2 commits intonx-dotnet:devfrom
Conversation
Do not include serve target for libraries as they cannot be run directly. Fixes #28
AgentEnder
requested changes
Apr 27, 2021
Member
AgentEnder
left a comment
AgentEnder
left a comment
There was a problem hiding this comment.
This looks good, and definitely works. One small suggestion, albeit a bit of a nit pick.
Replace boolean `and` with ternary for clearer code.
|
Kudos, SonarCloud Quality Gate passed!
|
Contributor
|
🎉 This PR is included in version 0.3.0-dev.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
AgentEnder
pushed a commit
that referenced
this pull request
Apr 27, 2021
Do not include serve target for libraries as they cannot be run directly. Fixes #28 Co-authored-by: Ben Callaghan <bcallaghan@selectbankcard.com>
github-actions bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
## [0.2.1-dev.1](v0.2.0...v0.2.1-dev.1) (2021-04-27) ### Bug Fixes * **core:** include serve target only for applications ([#30](#30)) ([d3a54ce](d3a54ce)), closes [#28](#28) * **core:** output paths still use windows separator on linux / mac ([ed1c53a](ed1c53a)) * **core:** use full project path in output directory ([7748f9c](7748f9c)), closes [#27](#27) ### Features * **repo:** enable semantic-release ([298c5af](298c5af))
github-actions bot
pushed a commit
that referenced
this pull request
Apr 27, 2021
## [0.2.1](v0.2.0...v0.2.1) (2021-04-27) ### Bug Fixes * **core:** include serve target only for applications ([#30](#30)) ([d3a54ce](d3a54ce)), closes [#28](#28) * **core:** output paths still use windows separator on linux / mac ([ed1c53a](ed1c53a)) * **core:** use full project path in output directory ([7748f9c](7748f9c)), closes [#27](#27) ### Features * **repo:** enable semantic-release ([298c5af](298c5af))
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not include serve target for libraries as they cannot be run directly.
Fixes #28