fix(core): app swaggerLib generation should work using dotnet pathScheme #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9514134. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
AgentEnder
approved these changes
Mar 10, 2023
codegenProject is generated using nrwl/js which applies nx file naming conventions. Codegen/swagger projects are json/ts libraries so they don't really have to follow dotnet conventions. This adds new nxFileName normalized option in project generator. This filename is not affected by pathScheme and is used for swaggerProject and codegenProject fixes #627
nxFileName -> nxProjectName
|
Kudos, SonarCloud Quality Gate passed!
|
github-actions bot
pushed a commit
that referenced
this pull request
Mar 10, 2023
# [1.20.0](v1.19.1...v1.20.0) (2023-03-10) ### Bug Fixes * **core:** add @trumbitta/nx-plugin-openapi via the Tree ([c2f2781](c2f2781)) * **core:** app generation should work in encapuslated Nx workspaces ([13c0a2c](13c0a2c)) * **core:** app swaggerLib generation should work using dotnet pathScheme ([#645](#645)) ([6443e32](6443e32)) * **core:** check glob for array length ([#647](#647)) ([8033f76](8033f76)) * **core:** handle null npm scope properly ([455199a](455199a)) * **core:** prevent stale cache entries from breaking swagger on dotnet upgrades ([#633](#633)) ([71f6893](71f6893)) * **core:** remove dependency on memfs and properly specify nx-plugin-openapi as optional peer dep ([cf8f8c3](cf8f8c3)) * **core:** remove dependency on workspace package.json ([d95a3ff](d95a3ff)) ### Features * **core:** nx 15.8.0 support ([897e1a0](897e1a0)) Mar 10, 2023, 5:11 PM
Contributor
|
🎉 This PR is included in version 1.20.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codegenProject is generated using nrwl/js which applies nx file naming conventions. Codegen/swagger projects are json/ts libraries so they don't really have to follow dotnet conventions. This adds new nxProjectName normalized option in project generator. This filename is not affected by pathScheme and is used for swaggerProject and codegenProject
fixes #627