Skip to content

fix(dotnet): update args handling for dotnet format#678

Merged
AgentEnder merged 1 commit intomasterfrom
fix/dotnet-format-changed-args
Sep 20, 2023
Merged

fix(dotnet): update args handling for dotnet format#678
AgentEnder merged 1 commit intomasterfrom
fix/dotnet-format-changed-args

Conversation

@AgentEnder
Copy link
Copy Markdown
Member

Updates dotnet client's format method to handle passing new args format that was introduced when the tool was brought into the dotnet CLI

This includes running 1-3 commands as needed rather than a single command since they no longer support disabling a single class of failure

Fixes: #623

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Apr 20, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 72bed7f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


🟥 Failed Commands
nx run-many --target=e2e --all
✅ Successfully ran 6 targets

Sent with 💌 from NxCloud.

@AgentEnder AgentEnder force-pushed the fix/dotnet-format-changed-args branch 2 times, most recently from b409500 to 72bed7f Compare April 20, 2023 18:49
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder force-pushed the fix/dotnet-format-changed-args branch 7 times, most recently from a9cbd3b to cf3cfd0 Compare September 20, 2023 03:31
@AgentEnder AgentEnder force-pushed the fix/dotnet-format-changed-args branch from cf3cfd0 to 3f88946 Compare September 20, 2023 03:57
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@AgentEnder AgentEnder merged commit 772303e into master Sep 20, 2023
@AgentEnder AgentEnder deleted the fix/dotnet-format-changed-args branch September 20, 2023 04:38
github-actions bot pushed a commit that referenced this pull request Sep 20, 2023
# [1.23.0](v1.22.0...v1.23.0) (2023-09-20)

### Bug Fixes

* **core:** add slash to use exact path ([#685](#685)) ([#687](#687)) ([1a87d83](1a87d83))
* **core:** codegen should not import self and default to required reference types ([#761](#761)) ([2310556](2310556))
* **core:** obey path in solution-file parameter when generating projects ([#762](#762)) ([29c234d](29c234d))
* **core:** support new name for enforce-module-boundaries eslint rule ([#742](#742)) ([24eb831](24eb831))
* **core:** update-swagger executor always reinstalls tool ([#757](#757)) ([63cf4b4](63cf4b4))
* **dotnet:** update args handling for dotnet format ([#678](#678)) ([772303e](772303e))

### Features

* **core:** add argument forwarding to dotnet new ([#722](#722)) ([cdc3654](cdc3654))
* **core:** make swagger tool run in project directory ([#758](#758)) ([12d89ac](12d89ac))

Sep 20, 2023, 3:59 PM
@github-actions
Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.23.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] lint executor options fixWhitespace and fixStyle provides invalid options to dotnet format (when > SDK 6.0.203)

1 participant