fix(core): move generator not updating paths correctly#767
fix(core): move generator not updating paths correctly#767AgentEnder merged 1 commit intonx-dotnet:masterfrom
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit f5e4001. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ⌛ The following target is in progress ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
b012cef to
933601d
Compare
AgentEnder
left a comment
There was a problem hiding this comment.
This looks good for the most part, one sm change requested that I think should clean it up.
933601d to
0d5d565
Compare
|
Lgtm, can you take care of the sonar code smell? |
0d5d565 to
6aa50ea
Compare
6aa50ea to
f5e4001
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Awesome, thanks for the contribution 🎉 |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |








Issue
project.json paths weren't being updated correctly
Steps to reproduce
nx g @nx-dotnet/core:lib my-libnx g @nx-dotnet/core:move --projectName my-lib --destination a/b/cnx g @nx-dotnet/core:move --projectName a-b-c --destination my-libExpected result
sourceRoot,outputPaths, etc should be pathed correctlyActual result
Note: when this issue was discovered we noted
$schemawas also incorrect following the generator. This hasn't been reproducible but does show itself in the added unit test.