-
Notifications
You must be signed in to change notification settings - Fork 68
feat(core): support allSourceTags (#768) and wildcards in check-module-boundaries.js #771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 56d4f2a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following target is in progress ✅ Successfully ran 7 targets
Sent with 💌 from NxCloud. |
AgentEnder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Tungsten78 👋
Thanks for the contribution. There are a few changes that I'd like before merging, but overall it's looking good and is a great addition to get things up to parity.
AgentEnder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, few sm changes
35b0c34 to
759dc5f
Compare
|
Can you rebase the PR? |
…eck-module-boundaries.js
0e8ea83 to
56d4f2a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
@Tungsten78 I seen the comment about the graph processing failing, did you figure that out locally? |
Yes, it was environment specific ( |
AgentEnder
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for the contribution 🎉, I'm planning a release soon with the Nx 16 updates.
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |









Addresses #768
Also adds regex and glob matching - another feature of @nx/eslint-plugin