Skip to content

fix(core): do not use --verify-no-changes false for linting#802

Merged
AgentEnder merged 2 commits intonx-dotnet:masterfrom
kellyrbourg:fix-dotnet-format
Nov 29, 2023
Merged

fix(core): do not use --verify-no-changes false for linting#802
AgentEnder merged 2 commits intonx-dotnet:masterfrom
kellyrbourg:fix-dotnet-format

Conversation

@kellyrbourg
Copy link
Contributor

These changes fix #797

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nx-cloud
Copy link

nx-cloud bot commented Nov 17, 2023

@kellyrbourg
Copy link
Contributor Author

@AgentEnder any advice on how to fix the e2e test failure?

@AgentEnder AgentEnder merged commit 9026fcf into nx-dotnet:master Nov 29, 2023
github-actions bot pushed a commit that referenced this pull request Nov 29, 2023
## [2.1.2](v2.1.1...v2.1.2) (2023-11-29)

### Bug Fixes

* **core:** do not use --verify-no-changes false for linting ([#802](#802)) ([9026fcf](9026fcf))

Nov 29, 2023, 4:01 PM
@github-actions
Copy link
Contributor

🎉 This PR is included in version 2.1.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@zagros
Copy link

zagros commented Nov 29, 2023

@kellyrbourg @AgentEnder

I still get the same issue:

image

and if I come to this file from your 2.1.2 release from 7 hours ago and manually delete the check to look like this it works

image

@github-actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Format boolean command line options don't work with false

3 participants