fix(dotnet): prevent "false" being incorrectly passed to dotnet command#818
Merged
AgentEnder merged 2 commits intonx-dotnet:masterfrom Jan 31, 2024
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3e06408. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
EchelonFour
force-pushed
the
bugfix/stop-passing-false-to-dotnet-commands
branch
from
bf3bd44 to
3e06408
Compare
|
AgentEnder
approved these changes
Jan 31, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
# [2.2.0](v2.1.2...v2.2.0) (2024-01-31) ### Bug Fixes * **core:** remove restriction of configuration ([#823](#823)) ([49b341f](49b341f)) * **dotnet:** prevent "false" being incorrectly passed to dotnet command ([#818](#818)) ([0945571](0945571)) ### Features * add options to sync the `gh-pages` branch with the base branch … ([#815](#815)) ([d9fff67](d9fff67)) * **core:** update inference configuration ([#822](#822)) ([6085c50](6085c50)) Jan 31, 2024, 10:32 PM
Contributor
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #812
Made the keys that need the word "false" an explicit thing to handle, since it seems to be the exception.
I am not sure if there are other flags that need to be this explicit false thing. I could only handle the ones that have test cases written.
I have also refactored the handling of converting options to params, since it is repeating the same calls over and over.