fix(core): remove restriction of configuration #823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change the schema.jsons for build and publish required the build configuration to be either Debug or Release. This change removes that restriction, allowing build configurations with other names
|
AgentEnder
approved these changes
Jan 30, 2024
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 6c1ea01. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 31, 2024
# [2.2.0](v2.1.2...v2.2.0) (2024-01-31) ### Bug Fixes * **core:** remove restriction of configuration ([#823](#823)) ([49b341f](49b341f)) * **dotnet:** prevent "false" being incorrectly passed to dotnet command ([#818](#818)) ([0945571](0945571)) ### Features * add options to sync the `gh-pages` branch with the base branch … ([#815](#815)) ([d9fff67](d9fff67)) * **core:** update inference configuration ([#822](#822)) ([6085c50](6085c50)) Jan 31, 2024, 10:32 PM
Contributor
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Contributor
Author
|
Holy crap, thanks for the speedy turnaround! |
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the schema.jsons for build and publish required the build configuration to be either Debug or Release. This change removes that restriction, allowing build configurations with other names.
I confirmed via monkey-patch that this fixes the issue in my local repository